Merge branch 'hm-make-change-status-spec-deterministic' into 'master'

[E2E] Make change vulnerability status spec deterministic

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/124047



Merged-by: Dan Davison <ddavison@gitlab.com>
Approved-by: John McDonnell <jmcdonnell@gitlab.com>
Approved-by: Dan Davison <ddavison@gitlab.com>
Co-authored-by: hmuralidhar <hmuralidhar@gitlab.com>

qa/qa/specs/features/ee/browser_ui/10_govern/change_vulnerability_status_spec.rb

@@ -31,10 +31,11 @@ module QA
       end
 
       let(:vuln_name) { "Greyhound vulnerability" }
-      # remove `'dismissed': 'dismiss'` until test can account for `dismissal_reason` feature flag
+      let(:dismissed_state) { "dismissed" }
+      let(:dismissal_reason) { "false_positive" }
+      let(:confirmed_state) { "confirmed" }
+      let(:resolved_state) { "resolved" }
       let(:vuln_status_hash) { { 'resolved': 'resolve', 'confirmed': 'confirm' } }
-      let(:vuln_status_sample) { vuln_status_hash.keys.sample.to_s }
-      let(:change_state) { vuln_status_hash[vuln_status_sample.to_sym] }
       let(:vuln_severity) { :CRITICAL }
 
       before do
@@ -53,31 +54,45 @@ module QA
         end
 
         EE::Page::Project::Secure::VulnerabilityDetails.perform do |vulnerability_details|
-          vulnerability_details.change_status(vuln_status_sample)
+          vulnerability_details.change_status(resolved_state)
 
-          expect(vulnerability_details).to have_vulnerability_status(vuln_status_sample)
+          expect(vulnerability_details).to have_vulnerability_status(resolved_state)
         end
         Page::Project::Menu.perform(&:go_to_vulnerability_report)
         EE::Page::Project::Secure::Show.perform do |security_dashboard|
-          security_dashboard.filter_by_status([vuln_status_sample])
+          security_dashboard.filter_by_status([resolved_state])
 
           expect(security_dashboard).to have_vulnerability(vuln_name)
         end
       end
 
-      it 'can successfully bulk change status in vulnerability report',
+      it 'can successfully bulk change status to confirmed in vulnerability report',
         testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/361405' do
         Page::Project::Menu.perform(&:go_to_vulnerability_report)
+        bulk_change_status(confirmed_state)
+        verify_changed_status(confirmed_state)
+      end
+
+      it 'can bulk dismiss vulnerabilities as false positive in vulnerability report',
+        testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/415647' do
+        Page::Project::Menu.perform(&:go_to_vulnerability_report)
+        bulk_change_status(dismissed_state)
+        verify_changed_status(dismissed_state)
+      end
+
+      def bulk_change_status(status)
         EE::Page::Project::Secure::SecurityDashboard.perform do |security_dashboard|
           security_dashboard.select_all_vulnerabilities
-          security_dashboard.change_state(vuln_status_sample)
+          security_dashboard.change_state(status)
         end
+      end
 
+      def verify_changed_status(status)
         EE::Page::Project::Secure::Show.perform do |security_dashboard|
-          security_dashboard.filter_by_status([vuln_status_sample])
+          security_dashboard.filter_by_status([status])
           vulnerabilities.each do |name, _description|
             expect(security_dashboard).to have_vulnerability(name)
-            expect(security_dashboard).to have_status(vuln_status_sample, name)
+            expect(security_dashboard).to have_status(status, name)
           end
         end
       end