Merge branch '343999-fix-codebase-to-ensure-the-uniqueness-of-graphql-fragment-names' into 'master'

Fix codebase to ensure the uniqueness of GraphQL fragment names

See merge request gitlab-org/gitlab!85383

.eslintrc.yml

@@ -99,7 +99,7 @@ rules:
       message: 'Migrate to GlSkeletonLoader, or import GlDeprecatedSkeletonLoading.'
 overrides:
   - files:
-    - '{,ee/,jh/}spec/frontend*/**/*'
+      - '{,ee/,jh/}spec/frontend*/**/*'
     rules:
       '@gitlab/require-i18n-strings': off
       '@gitlab/no-runtime-template-compiler': off
@@ -139,13 +139,11 @@ overrides:
       parser: '@graphql-eslint/eslint-plugin'
       operations:
         - '{,ee/,jh/}app/**/*.graphql'
-        # You can run `bundle exec rake gitlab:graphql:schema:dump` and then uncomment this line
-        # schema: './tmp/tests/graphql/gitlab_schema.graphql'
+      # You can run `bundle exec rake gitlab:graphql:schema:dump` and then uncomment this line
+      # schema: './tmp/tests/graphql/gitlab_schema.graphql'
     rules:
       filenames/match-regex: off
       spaced-comment: off
-      # TODO: We need a way to include this rule + support ee_else_ce fragments
-      #'@graphql-eslint/unique-fragment-name': error
       # TODO: Uncomment these rules when then `schema` is available
       #'@graphql-eslint/fragments-on-composite-type': error
       #'@graphql-eslint/known-argument-names': error
@@ -153,3 +151,4 @@ overrides:
       '@graphql-eslint/no-anonymous-operations': error
       '@graphql-eslint/unique-operation-name': error
       '@graphql-eslint/require-id-when-available': error
+      '@graphql-eslint/unique-fragment-name': error

app/assets/javascripts/alerts_settings/graphql/fragments/http_integration_payload_data.fragment.graphql

+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment HttpIntegrationPayloadData on AlertManagementHttpIntegration {
   id
 }

app/assets/javascripts/boards/graphql/board.fragment.graphql

+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment BoardFragment on Board {
   id
   name

app/assets/javascripts/boards/graphql/board_list.fragment.graphql

 #import "./board_list_shared.fragment.graphql"
 
+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment BoardListFragment on BoardList {
   ...BoardListShared
 }

app/assets/javascripts/boards/graphql/board_scope.fragment.graphql

+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment BoardScopeFragment on Board {
   id
   name

app/assets/javascripts/boards/graphql/issue.fragment.graphql

 #import "~/graphql_shared/fragments/issue.fragment.graphql"
 
+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment Issue on Issue {
   id
   ...IssueNode

app/assets/javascripts/graphql_shared/fragments/iteration.fragment.graphql

-fragment Iteration on Iteration {
+fragment IterationShared on Iteration {
   id
   title
 }

app/assets/javascripts/graphql_shared/fragments/page_info_cursors_only.fragment.graphql

-fragment PageInfo on PageInfo {
-  startCursor
-  endCursor
-}

app/assets/javascripts/incidents/graphql/fragments/incident_fields.fragment.graphql

-# eslint-disable-next-line @graphql-eslint/require-id-when-available
+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/require-id-when-available, @graphql-eslint/unique-fragment-name
 fragment IncidentFields on Issue {
   severity
   escalationStatus

app/assets/javascripts/issues/list/queries/label.fragment.graphql

-fragment Label on Label {
-  id
-  color
-  textColor
-  title
-}

app/assets/javascripts/issues/list/queries/search_labels.query.graphql

-#import "./label.fragment.graphql"
+#import "~/graphql_shared/fragments/label.fragment.graphql"
 
 query searchLabels($fullPath: ID!, $search: String, $isProject: Boolean = false) {
   group(fullPath: $fullPath) @skip(if: $isProject) {

app/assets/javascripts/issues/list/queries/search_users.query.graphql

-#import "./user.fragment.graphql"
+#import "~/graphql_shared/fragments/user.fragment.graphql"
 
 query searchUsers($fullPath: ID!, $search: String, $isProject: Boolean = false) {
   group(fullPath: $fullPath) @skip(if: $isProject) {

app/assets/javascripts/issues/list/queries/user.fragment.graphql

-fragment User on User {
-  id
-  avatarUrl
-  name
-  username
-}

app/assets/javascripts/repository/queries/commit.fragment.graphql

+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment TreeEntryCommit on LogTreeCommit {
   sha
   message

app/assets/javascripts/repository/queries/path_locks.fragment.graphql

+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment ProjectPathLocksFragment on Project {
   id
 }

app/assets/javascripts/runner/graphql/details/runner_details.fragment.graphql

 #import "./runner_details_shared.fragment.graphql"
 
+# This fragment is used as ee-else-ce
+# eslint-disable-next-line @graphql-eslint/unique-fragment-name
 fragment RunnerDetails on CiRunner {
   ...RunnerDetailsShared
 }

app/assets/javascripts/sidebar/queries/group_milestones.query.graphql

@@ -12,7 +12,7 @@ query groupMilestones($fullPath: ID!, $title: String, $state: MilestoneStateEnum
       includeAncestors: true
     ) {
       nodes {
-        ...MilestoneFragment
+        ...SidebarMilestoneFragment
         state
       }
     }

app/assets/javascripts/sidebar/queries/merge_request_milestone.query.graphql

@@ -8,7 +8,7 @@ query mergeRequestMilestone($fullPath: ID!, $iid: String!) {
       __typename
       id
       attribute: milestone {
-        ...MilestoneFragment
+        ...SidebarMilestoneFragment
       }
     }
   }

app/assets/javascripts/sidebar/queries/milestone.fragment.graphql

-fragment MilestoneFragment on Milestone {
+fragment SidebarMilestoneFragment on Milestone {
   id
   title
   webUrl: webPath

app/assets/javascripts/sidebar/queries/project_issue_milestone.query.graphql

@@ -8,7 +8,7 @@ query projectIssueMilestone($fullPath: ID!, $iid: String!) {
       __typename
       id
       attribute: milestone {
-        ...MilestoneFragment
+        ...SidebarMilestoneFragment
       }
     }
   }