Merge branch 'fa-fix_dora_executor_period_time_parameter' into 'master'

Accept period_time as string on DORA executor

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/123975



Merged-by: Jessie Young <jessieyoung@gitlab.com>
Approved-by: Adam Hegyi <ahegyi@gitlab.com>
Approved-by: Jessie Young <jessieyoung@gitlab.com>
Co-authored-by: Felipe Artur <felipefac@gmail.com>

ee/lib/gitlab/insights/executors/dora_executor.rb

@@ -100,7 +100,10 @@ def start_date
         end
 
         def period_limit
-          query_params[:period_limit] || 15
+          @period_limit ||= begin
+            limit = query_params[:period_limit].to_i
+            limit > 0 ? limit : 15
+          end
         end
 
         def dora_interval

ee/spec/lib/gitlab/insights/executors/dora_executor_spec.rb

@@ -194,5 +194,35 @@ def deployment_frequency(date, count)
         end
       end
     end
+
+    context 'when period_limit is a string' do
+      let(:query_params) do
+        {
+          metric: 'deployment_frequency',
+          group_by: 'month',
+          period_limit: "5"
+        }
+      end
+
+      it 'returns correctly aggregated data' do
+        expected_result = [0, deployment_frequency(date2, 50), 0, deployment_frequency(date1, 5), 0]
+
+        expect(serialized_data['datasets'].first['data']).to eq(expected_result)
+      end
+
+      context 'when is a invalid string' do
+        let(:query_params) do
+          {
+            metric: 'deployment_frequency',
+            group_by: 'day',
+            period_limit: "a invalid string"
+          }
+        end
+
+        it 'uses default of 15' do
+          expect(serialized_data['datasets'].first['data'].size).to eq(15)
+        end
+      end
+    end
   end
 end