Merge branch 'issue_406761-job_artifact_spec' into 'master'

RSpec/UselessDynamicDefinition: Fix current offenses

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/118609



Merged-by: drew stachon <730684-drew@users.noreply.gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: drew stachon <730684-drew@users.noreply.gitlab.com>
Co-authored-by: Ashutosh Gupta <ashutoshgupta1311@gmail.com>

spec/models/ci/job_artifact_spec.rb

@@ -483,9 +483,11 @@
 
       context "when #{file_type} type with other formats" do
         described_class.file_formats.except(file_format).values.each do |other_format|
-          let(:artifact) { build(:ci_job_artifact, file_type: file_type, file_format: other_format) }
+          context "with #{other_format}" do
+            let(:artifact) { build(:ci_job_artifact, file_type: file_type, file_format: other_format) }
 
-          it { is_expected.not_to be_valid }
+            it { is_expected.not_to be_valid }
+          end
         end
       end
     end