Merge branch '363023-rm-ff-last-deployment-group' into 'master'

Remove FF for last-deployment-group

See merge request gitlab-org/gitlab!92976

app/models/environment.rb

@@ -331,11 +331,7 @@ def stop_actions
   end
 
   def last_deployment_group
-    if ::Feature.enabled?(:batch_load_environment_last_deployment_group, project)
-      Deployment.last_deployment_group_for_environment(self)
-    else
-      legacy_last_deployment_group
-    end
+    Deployment.last_deployment_group_for_environment(self)
   end
 
   def reset_auto_stop

app/serializers/environment_serializer.rb

@@ -56,10 +56,6 @@ def batch_load(resource)
 
     resource = resource.preload(environment_associations.except(:last_deployment, :upcoming_deployment))
 
-    if ::Feature.enabled?(:batch_load_environment_last_deployment_group, resource.first&.project)
-      temp_deployment_associations[:deployable][:pipeline][:latest_successful_builds] = []
-    end
-
     Preloaders::Environments::DeploymentPreloader.new(resource)
       .execute_with_union(:last_deployment, temp_deployment_associations)
 
@@ -72,10 +68,8 @@ def batch_load(resource)
         environment.last_deployment&.commit&.try(:lazy_author)
         environment.upcoming_deployment&.commit&.try(:lazy_author)
 
-        if ::Feature.enabled?(:batch_load_environment_last_deployment_group, environment.project)
-          # Batch loading last_deployment_group which is called later by environment.stop_actions
-          environment.last_deployment_group
-        end
+        # Batch loading last_deployment_group which is called later by environment.stop_actions
+        environment.last_deployment_group
       end
     end
   end
@@ -101,7 +95,8 @@ def deployment_associations
         metadata: [],
         pipeline: {
           manual_actions: [:metadata, :deployment],
-          scheduled_actions: [:metadata]
+          scheduled_actions: [:metadata],
+          latest_successful_builds: []
         },
         project: project_associations,
         deployment: []

config/feature_flags/development/batch_load_environment_last_deployment_group.yml

----
-name: batch_load_environment_last_deployment_group
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/86584/
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/363023
-milestone: '15.1'
-type: development
-group: group::release
-default_enabled: true

spec/models/environment_spec.rb

@@ -856,16 +856,6 @@
       it 'returns the successful deployment jobs for the last deployment pipeline' do
         expect(subject.pluck(:id)).to contain_exactly(deployment_a.id, deployment_b.id)
       end
-
-      context 'when the feature flag is disabled' do
-        before do
-          stub_feature_flags(batch_load_environment_last_deployment_group: false)
-        end
-
-        it 'returns the successful deployment jobs for the last deployment pipeline' do
-          expect(subject.pluck(:id)).to contain_exactly(deployment_a.id, deployment_b.id)
-        end
-      end
     end
   end