Merge branch 'g385353-dequarantine-github-mirror-spec' into 'master'

Dequarantines `pipeline_for_project_mirror_github_spec`

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115747



Merged-by: Tiffany Rea <trea@gitlab.com>
Approved-by: Tiffany Rea <trea@gitlab.com>
Approved-by: John McDonnell <jmcdonnell@gitlab.com>
Reviewed-by: Andrejs Cunskis <acunskis@gitlab.com>
Reviewed-by: Richard Chong <rchong@gitlab.com>
Co-authored-by: Richard Chong <rchong@gitlab.com>

qa/qa/page/project/import/github.rb

@@ -71,7 +71,11 @@ def has_go_to_project_link?(gh_project_name)
           # @param [String] source_project_name
           # @param [Integer] wait
           # @return [Boolean]
-          def has_imported_project?(gh_project_name, wait: QA::Support::WaitForRequests::DEFAULT_MAX_WAIT_TIME)
+          def has_imported_project?(
+            gh_project_name,
+            wait: QA::Support::WaitForRequests::DEFAULT_MAX_WAIT_TIME,
+            allow_partial_import: false
+          )
             within_element(:project_import_row, source_project: gh_project_name, skip_finished_loading_check: true) do
               wait_until(
                 max_duration: wait,
@@ -80,18 +84,12 @@ def has_imported_project?(gh_project_name, wait: QA::Support::WaitForRequests::D
                 skip_finished_loading_check_on_refresh: true
               ) do
                 status_selector = 'import_status_indicator'
-                is_partial_import = has_css?(status_selector, text: 'Partially completed')
 
-                # Temporarily adding this for investigation purposes. This makes sure that the details section is
-                # expanded when the screenshot is taken when the test fails. This can be removed or repurposed later
-                # after investigation. Related: https://gitlab.com/gitlab-org/gitlab/-/issues/385252#note_1211218434
-                if is_partial_import
-                  within_element_by_index(:import_status_indicator, 0) do
-                    find('button').click
-                  end
-                end
+                return has_element?(status_selector, text: "Complete", wait: 1) unless allow_partial_import # rubocop:disable Cop/AvoidReturnFromBlocks
 
-                has_element?(status_selector, text: "Complete")
+                ["Partially completed", "Complete"].any? do |status|
+                  has_element?(status_selector, text: status, wait: 1)
+                end
               end
             end
           end

qa/qa/resource/project_imported_from_github.rb

@@ -3,7 +3,7 @@
 module QA
   module Resource
     class ProjectImportedFromGithub < Resource::Project
-      attr_accessor :issue_events_import, :full_notes_import, :attachments_import
+      attr_accessor :issue_events_import, :full_notes_import, :attachments_import, :allow_partial_import
 
       attribute :github_repo_id do
         github_client.repository(github_repository_path).id
@@ -24,7 +24,7 @@ def fabricate!
           import_page.select_advanced_option(:attachments_import) if attachments_import
 
           import_page.import!(github_repository_path, group.full_path, name)
-          import_page.wait_for_success(github_repository_path, wait: 240)
+          import_page.wait_for_success(github_repository_path, wait: 240, allow_partial_import: allow_partial_import)
         end
 
         reload!

qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_for_project_mirror_github_spec.rb

@@ -4,10 +4,7 @@
 
 module QA
   describe 'Verify', :github, :requires_admin, only: { subdomain: %i[staging staging-canary] } do
-    describe 'Pipeline for project mirrors Github', product_group: :pipeline_execution, quarantine: {
-      type: :investigating,
-      issue: "https://gitlab.com/gitlab-org/gitlab/-/issues/385252"
-    } do
+    describe 'Pipeline for project mirrors Github', product_group: :pipeline_execution do
       include QA::Support::Data::Github
 
       let(:commit_message) { "Update #{github_data[:file_name]} - #{Time.now}" }
@@ -44,6 +41,7 @@ module QA
           project.github_personal_access_token = github_data[:access_token]
           project.github_repository_path = github_data[:repo]
           project.api_client = user_api_client
+          project.allow_partial_import = true
         end
       end