Merge branch 'notes-urgency-low' into 'master'

Revert urgency of notes endpoint to low

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/130207



Merged-by: Kerri Miller <kerrizor@kerrizor.com>
Approved-by: Hercules Merscher <hmerscher@gitlab.com>
Approved-by: Kerri Miller <kerrizor@kerrizor.com>
Co-authored-by: Heinrich Lee Yu <heinrich@gitlab.com>

app/controllers/projects/notes_controller.rb

@@ -14,8 +14,7 @@ class Projects::NotesController < Projects::ApplicationController
 
   feature_category :team_planning, [:index, :create, :update, :destroy, :delete_attachment, :toggle_award_emoji]
   feature_category :code_review_workflow, [:resolve, :unresolve, :outdated_line_change]
-  urgency :medium, [:index]
-  urgency :low, [:create, :update, :destroy, :resolve, :unresolve, :toggle_award_emoji, :outdated_line_change]
+  urgency :low
 
   override :feature_category
   def feature_category

spec/controllers/projects/notes_controller_spec.rb

@@ -40,7 +40,7 @@
       request.headers['X-Last-Fetched-At'] = microseconds(last_fetched_at)
     end
 
-    specify { expect(get(:index, params: request_params)).to have_request_urgency(:medium) }
+    specify { expect(get(:index, params: request_params)).to have_request_urgency(:low) }
 
     it 'sets the correct feature category' do
       get :index, params: request_params

spec/lib/gitlab/etag_caching/middleware_spec.rb

@@ -124,8 +124,8 @@
         method: 'GET',
         path: enabled_path,
         status: status_code,
-        request_urgency: :medium,
-        target_duration_s: 0.5,
+        request_urgency: :low,
+        target_duration_s: 5,
         metadata: a_hash_including(
           {
             'meta.caller_id' => 'Projects::NotesController#index',

spec/requests/projects/noteable_notes_spec.rb

@@ -45,7 +45,7 @@
       expect(Gitlab::Metrics::RailsSlis.request_apdex).to(
         receive(:increment).with(
           labels: {
-            request_urgency: :medium,
+            request_urgency: :low,
             feature_category: "team_planning",
             endpoint_id: "Projects::NotesController#index"
           },
@@ -59,8 +59,8 @@
           'process_action.action_controller',
           a_hash_including(
             {
-              request_urgency: :medium,
-              target_duration_s: 0.5,
+              request_urgency: :low,
+              target_duration_s: 5,
               metadata: a_hash_including({
                 'meta.feature_category' => 'team_planning',
                 'meta.caller_id' => "Projects::NotesController#index"