Merge branch 'rm-env' into 'master'

Refactor: Removes index protected environment

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/139875



Merged-by: Leonardo da Rosa <ldarosa@gitlab.com>
Approved-by: Leonardo da Rosa <ldarosa@gitlab.com>
Reviewed-by: Pam Artiaga <partiaga@gitlab.com>
Reviewed-by: Leonardo da Rosa <ldarosa@gitlab.com>
Co-authored-by: Afzal Ansari <afzal442@gmail.com>

db/post_migrate/20240117070119_remove_index_protected_environments_on_project_id.rb

+# frozen_string_literal: true
+
+class RemoveIndexProtectedEnvironmentsOnProjectId < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+
+  milestone '16.9'
+
+  INDEX_NAME = 'index_protected_environments_on_project_id'
+
+  def up
+    remove_concurrent_index_by_name :protected_environments, name: INDEX_NAME
+  end
+
+  def down
+    add_concurrent_index :protected_environments, :project_id, name: INDEX_NAME
+  end
+end

db/schema_migrations/20240117070119

+1becea9a8277072f40d0fa7325338ae92e698b39e7c84b1be8ffe52832ef6794
\ No newline at end of file

db/structure.sql

@@ -35115,8 +35115,6 @@ CREATE INDEX index_protected_environments_on_approval_count_and_created_at ON pr
 CREATE UNIQUE INDEX index_protected_environments_on_group_id_and_name ON protected_environments USING btree (group_id, name) WHERE (group_id IS NOT NULL);
-CREATE INDEX index_protected_environments_on_project_id ON protected_environments USING btree (project_id);
-
 CREATE UNIQUE INDEX index_protected_environments_on_project_id_and_name ON protected_environments USING btree (project_id, name);
 CREATE INDEX index_protected_tag_create_access ON protected_tag_create_access_levels USING btree (protected_tag_id);

spec/support/helpers/database/duplicate_indexes.yml

@@ -125,9 +125,6 @@ project_compliance_standards_adherence:
 project_repositories:
   index_project_repositories_on_shard_id_and_project_id:
     - index_project_repositories_on_shard_id
-protected_environments:
-  index_protected_environments_on_project_id_and_name:
-    - index_protected_environments_on_project_id
 protected_tags:
   index_protected_tags_on_project_id_and_name:
     - index_protected_tags_on_project_id