Skip to content
代码片段 群组 项目
提交 62a478c7 编辑于 作者: James Nutt's avatar James Nutt
浏览文件

Add path to feature flag fallback note

The current fallback note for an unfilled `feature_issue_url:` does not
provide enough context to make it obvious what it's referring to. This
MR adds the file path to direct the author of the MR in the right
direction.

Before:

```
- [ ] config/feature_flags/beta/flag_with_blank_feature_url.yml#L3: Consider filling `feature_issue_url:`
- [ ] Consider filling `feature_issue_url:`
```

After:

```
- [ ] config/feature_flags/beta/flag_with_blank_feature_url.yml#L3: Consider filling `feature_issue_url:`
- [ ] config/feature_flags/beta/flag_with_missing_feature_url.yml: Consider filling `feature_issue_url:`
```
上级 32638610
No related branches found
No related tags found
无相关合并请求
...@@ -151,7 +151,7 @@ module Tooling ...@@ -151,7 +151,7 @@ module Tooling
if mr_line if mr_line
context.public_send(message_method, note, file: feature_flag.path, line: mr_line.succ) context.public_send(message_method, note, file: feature_flag.path, line: mr_line.succ)
else else
context.public_send(message_method, fallback_note) context.public_send(message_method, "#{feature_flag.path}: #{fallback_note}")
end end
# rubocop:enable GitlabSecurity/PublicSend # rubocop:enable GitlabSecurity/PublicSend
end end
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册