Merge branch 'sh-clean-pgvector' into 'main'

Run pgvector-clean before pgvector-setup

See merge request https://gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/3412



Merged-by: Nao Hashizume <nhashizume@gitlab.com>
Approved-by: Nao Hashizume <nhashizume@gitlab.com>
Co-authored-by: Stan Hu <stanhu@gmail.com>

lib/gdk/postgresql_upgrader.rb

@@ -107,8 +107,8 @@ def rename_current_data_dir_back
     def pgvector_setup
       return unless config.gitlab.rails.databases.embedding.enabled?
 
-      GDK::Output.info "Running 'make pgvector-setup'.."
-      run!('make pgvector-setup', config.gdk_root)
+      GDK::Output.info "Running 'make pgvector-clean pgvector-setup'.."
+      run!('make pgvector-clean pgvector-setup', config.gdk_root)
     end
 
     def pg_upgrade