Fix quarantined internal event matcher spec

spec/support_specs/matchers/internal_events_matchers_spec.rb

@@ -53,22 +53,21 @@ def track_event(event: nil, user: nil, group: nil)
     it 'bubbles up failure messages' do
       expect do
         expect { nil }.to trigger_internal_events('g_edit_by_sfe')
-      end.to raise_error RSpec::Expectations::ExpectationNotMetError,
-        "(Gitlab::InternalEvents).track_event(\"g_edit_by_sfe\", *(any args))\n    " \
-          "expected: 1 time with arguments: (\"g_edit_by_sfe\", *(any args))\n    " \
-          "received: 0 times"
+      end.to raise_expectation_error_with <<~TEXT
+        (Gitlab::InternalEvents).track_event("g_edit_by_sfe", *(any args))
+            expected: 1 time with arguments: ("g_edit_by_sfe", *(any args))
+            received: 0 times
+      TEXT
     end
 
-    it 'bubbles up failure messages for negated matcher',
-      quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/463147' do
+    it 'bubbles up failure messages for negated matcher' do
       expect do
         expect { track_event }.not_to trigger_internal_events('g_edit_by_sfe')
-      end.to raise_error RSpec::Expectations::ExpectationNotMetError,
-        "(Gitlab::InternalEvents).track_event(\"g_edit_by_sfe\", " \
-          "{:namespace=>#<Group id:#{group_1.id} @group1>, :user=>#<User id:#{user_1.id} @user1>})\n    " \
-          "expected: 0 times with arguments: (\"g_edit_by_sfe\", anything)\n    " \
-          "received: 1 time with arguments: (\"g_edit_by_sfe\", " \
-          "{:namespace=>#<Group id:#{group_1.id} @group1>, :user=>#<User id:#{user_1.id} @user1>})"
+      end.to raise_expectation_error_with <<~TEXT
+        (Gitlab::InternalEvents).track_event("g_edit_by_sfe", {:namespace=>#<Group id:#{group_1.id} @#{group_1.name}>, :user=>#<User id:#{user_1.id} @#{user_1.username}>})
+            expected: 0 times with arguments: ("g_edit_by_sfe", anything)
+            received: 1 time with arguments: ("g_edit_by_sfe", {:namespace=>#<Group id:#{group_1.id} @#{group_1.name}>, :user=>#<User id:#{user_1.id} @#{user_1.username}>})
+      TEXT
     end
 
     it 'handles events that should not be triggered' do
@@ -176,9 +175,10 @@ def track_event(event: nil, user: nil, group: nil)
         end
 
         it 'returns a meaningful failure message for :increment_usage_metrics' do
-          expect { assertion }.to raise_error RSpec::Expectations::ExpectationNotMetError,
-            "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly to be incremented by 1\n  " \
-              "->  value went from 0 to 0"
+          expect { assertion }.to raise_expectation_error_with <<~TEXT
+            expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly to be incremented by 1
+              ->  value went from 0 to 0
+          TEXT
         end
       end
 
@@ -191,11 +191,12 @@ def track_event(event: nil, user: nil, group: nil)
         end
 
         it 'returns a meaningful failure message for :increment_usage_metrics' do
-          expect { assertion }.to raise_error RSpec::Expectations::ExpectationNotMetError,
-            "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly to be incremented by 1\n  " \
-              "->  value went from 0 to 0\n" \
-              "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly to be incremented by 1\n  " \
-              "->  value went from 0 to 0"
+          expect { assertion }.to raise_expectation_error_with <<~TEXT
+            expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly to be incremented by 1
+              ->  value went from 0 to 0
+            expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly to be incremented by 1
+              ->  value went from 0 to 0
+          TEXT
         end
       end
 
@@ -207,12 +208,15 @@ def track_event(event: nil, user: nil, group: nil)
         end
 
         it 'returns a meaningful failure message for :increment_usage_metrics' do
-          expect { assertion }.to raise_error RSpec::Expectations::ExpectationNotMetError,
-            "   expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly " \
-              "to be incremented by 1\n     ->  value went from 0 to 0\n\n" \
-              "...and:\n\n   " \
-              "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly " \
-              "to be incremented by 1\n     ->  value went from 0 to 0"
+          expect { assertion }.to raise_expectation_error_with <<~TEXT
+             expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly to be incremented by 1
+               ->  value went from 0 to 0
+
+          ...and:
+
+             expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly to be incremented by 1
+               ->  value went from 0 to 0
+          TEXT
         end
       end
     end
@@ -225,9 +229,10 @@ def track_event(event: nil, user: nil, group: nil)
         end
 
         it 'returns a meaningful failure message for :increment_usage_metrics' do
-          expect { assertion }.to raise_error RSpec::Expectations::ExpectationNotMetError,
-            "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly not to be incremented\n  " \
-              "->  value went from 0 to 1"
+          expect { assertion }.to raise_expectation_error_with <<~TEXT
+            expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly not to be incremented
+              ->  value went from 0 to 1
+          TEXT
         end
       end
 
@@ -240,11 +245,12 @@ def track_event(event: nil, user: nil, group: nil)
         end
 
         it 'returns a meaningful failure message for :increment_usage_metrics' do
-          expect { assertion }.to raise_error RSpec::Expectations::ExpectationNotMetError,
-            "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly not to be incremented\n  " \
-              "->  value went from 0 to 1\n" \
-              "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly not to be incremented\n  " \
-              "->  value went from 0 to 1"
+          expect { assertion }.to raise_expectation_error_with <<~TEXT
+            expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly not to be incremented
+              ->  value went from 0 to 1
+            expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly not to be incremented
+              ->  value went from 0 to 1
+          TEXT
         end
       end
 
@@ -256,12 +262,15 @@ def track_event(event: nil, user: nil, group: nil)
         end
 
         it 'returns a meaningful failure message for :increment_usage_metrics' do
-          expect { assertion }.to raise_error RSpec::Expectations::ExpectationNotMetError,
-            "   expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly " \
-              "not to be incremented\n     ->  value went from 0 to 1\n\n" \
-              "...and:\n\n   " \
-              "expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly " \
-              "not to be incremented\n     ->  value went from 0 to 1"
+          expect { assertion }.to raise_expectation_error_with <<~TEXT
+             expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_weekly not to be incremented
+               ->  value went from 0 to 1
+
+          ...and:
+
+             expected metric redis_hll_counters.ide_edit.g_edit_by_sfe_monthly not to be incremented
+               ->  value went from 0 to 1
+          TEXT
         end
       end
     end
@@ -389,4 +398,14 @@ def track_event(event: nil, user: nil, group: nil)
       end
     end
   end
+
+  private
+
+  def raise_expectation_error_with(error_message)
+    error_matcher = an_object_satisfying do |actual_message|
+      expect(actual_message).to eq error_message.chomp
+    end
+
+    raise_error RSpec::Expectations::ExpectationNotMetError, error_matcher
+  end
 end