Merge branch 'bmarjanovic/fix-potential-bc' into 'master'

Fix code suggestions order issue

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127453



Merged-by: Jan Provaznik <jprovaznik@gitlab.com>
Approved-by: Nicolas Dular <ndular@gitlab.com>
Approved-by: Jan Provaznik <jprovaznik@gitlab.com>
Co-authored-by: bmarjanovic <bmarjanovic@gitlab.com>

ee/lib/api/code_suggestions.rb

@@ -23,8 +23,8 @@ def user_allowed?
       end
 
       def active_code_suggestions_purchase?(project_id)
-        return false unless project_id
         return true unless ::Feature.enabled?(:purchase_code_suggestions)
+        return false unless project_id
 
         cache_key = format(PROJECT_CODE_SUGGESTIONS_ADD_ON_CACHE_KEY, project_id: project_id)
         Rails.cache.fetch(cache_key, expires_in: 1.hour) do

ee/spec/requests/api/code_suggestions_spec.rb

@@ -333,7 +333,7 @@
           stub_feature_flags(purchase_code_suggestions: false)
         end
 
-        include_examples 'a not found response'
+        it_behaves_like 'code completions endpoint'
       end
     end