Merge branch 'add_WithoutReactiveCache' into 'master'

Move Cop/WithoutReactiveCache to gitlab-org/gitlab

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/164279



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Martin Schurz <Martin.Schurz@telekom.de>

.rubocop.yml

@@ -95,6 +95,11 @@ Cop/StaticTranslationDefinition:
     - 'spec/**/*'
     - 'ee/spec/**/*'
 
+# Disable old cop, needs to be removed when gitlab-styles 13.0.0 is merged
+# see: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/164582
+Cop/WithoutReactiveCache:
+  Enabled: false
+
 InternalAffairs/DeprecateCopHelper:
   Enabled: true
   Include:

rubocop/cop/gitlab/without_reactive_cache.rb

+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Gitlab
+      # Cop that prevents the use of `without_reactive_cache`
+      class WithoutReactiveCache < RuboCop::Cop::Base
+        MSG = 'without_reactive_cache is for debugging purposes only. Please use with_reactive_cache.'
+
+        RESTRICT_ON_SEND = %i[without_reactive_cache].freeze
+
+        def on_send(node)
+          add_offense(node.loc.selector)
+        end
+      end
+    end
+  end
+end

spec/rubocop/cop/gitlab/without_reactive_cache_spec.rb

+# frozen_string_literal: true
+
+require 'rubocop_spec_helper'
+require_relative '../../../../rubocop/cop/gitlab/without_reactive_cache'
+
+RSpec.describe RuboCop::Cop::Gitlab::WithoutReactiveCache, feature_category: :shared do
+  it 'registers an offense when without_reactive_cache is used' do
+    expect_offense(<<~RUBY)
+      without_reactive_cache do; end
+      ^^^^^^^^^^^^^^^^^^^^^^ without_reactive_cache is for debugging purposes only. Please use with_reactive_cache.
+    RUBY
+  end
+
+  it 'does not flag unsupported methods' do
+    expect_no_offenses(<<~RUBY)
+      something_else do; end
+    RUBY
+  end
+end