RuboCop: Enable previously disabled Style/RedundantInterpolation

Changelog: other

.haml-lint.yml

@@ -135,6 +135,7 @@ linters:
       - Style/NestedTernaryOperator
       - Style/SelfAssignment
       - Style/StringConcatenation
+      - Style/RedundantInterpolation
       - Style/TernaryParentheses
       - Style/TrailingCommaInHashLiteral
       - Style/UnlessElse

.rubocop_todo/style/redundant_interpolation.yml

 ---
 # Cop supports --auto-correct.
 Style/RedundantInterpolation:
-  # Offense count: 285
-  # Temporarily disabled due to too many offenses
-  Enabled: false
   Exclude:
     - 'app/components/diffs/stats_component.rb'
     - 'app/helpers/blob_helper.rb'
@@ -13,7 +10,10 @@ Style/RedundantInterpolation:
     - 'app/helpers/environments_helper.rb'
     - 'app/helpers/icons_helper.rb'
     - 'app/helpers/issuables_helper.rb'
+    - 'app/helpers/nav_helper.rb'
+    - 'app/helpers/projects_helper.rb'
     - 'app/helpers/search_helper.rb'
+    - 'app/helpers/tooling/visual_review_helper.rb'
     - 'app/models/concerns/issuable.rb'
     - 'app/models/integrations/base_chat_notification.rb'
     - 'app/models/integrations/hangouts_chat.rb'
@@ -24,6 +24,7 @@ Style/RedundantInterpolation:
     - 'app/services/users/approve_service.rb'
     - 'app/services/users/banned_user_base_service.rb'
     - 'app/services/users/reject_service.rb'
+    - 'db/post_migrate/20220420214703_schedule_backfill_draft_status_on_merge_requests_corrected_regex.rb'
     - 'ee/app/graphql/types/compliance_management/merge_requests/compliance_violation_reason_enum.rb'
     - 'ee/app/graphql/types/incident_management/oncall_rotation_length_unit_enum.rb'
     - 'ee/app/helpers/ee/ci/runners_helper.rb'
@@ -31,23 +32,29 @@ Style/RedundantInterpolation:
     - 'ee/app/services/geo/event_store.rb'
     - 'ee/app/services/geo/repository_updated_service.rb'
     - 'ee/app/services/security/security_orchestration_policies/create_pipeline_service.rb'
+    - 'ee/app/services/users/abuse/excessive_projects_download_ban_service.rb'
+    - 'ee/app/services/users/abuse/git_abuse/namespace_throttle_service.rb'
     - 'ee/db/fixtures/development/31_devops_adoption.rb'
+    - 'ee/lib/gitlab/insights/serializers/chartjs/base_serializer.rb'
     - 'ee/spec/features/epics/epic_issues_spec.rb'
     - 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb'
     - 'ee/spec/features/registrations/one_trust_spec.rb'
     - 'ee/spec/graphql/ee/mutations/boards/lists/create_spec.rb'
     - 'ee/spec/lib/banzai/filter/issuable_reference_expansion_filter_spec.rb'
     - 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb'
-    - 'ee/spec/lib/ee/audit/protected_branches_changes_auditor_spec.rb'
     - 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb'
+    - 'ee/spec/lib/gitlab/insights/serializers/chartjs/line_serializer_spec.rb'
+    - 'ee/spec/lib/gitlab/insights/serializers/chartjs/multi_series_serializer_spec.rb'
     - 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb'
     - 'ee/spec/mailers/emails/namespace_storage_usage_mailer_spec.rb'
     - 'ee/spec/mailers/notify_spec.rb'
     - 'ee/spec/models/incident_management/issuable_escalation_status_spec.rb'
     - 'ee/spec/requests/api/issues_spec.rb'
     - 'ee/spec/requests/api/search_spec.rb'
+    - 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb'
     - 'ee/spec/services/search_service_spec.rb'
     - 'ee/spec/services/timebox_report_service_spec.rb'
+    - 'ee/spec/support/shared_contexts/lib/gitlab/insights/serializers/serializers_shared_context.rb'
     - 'ee/spec/support/shared_examples/lib/gitlab/elastic/standalone_indices_shared_examples.rb'
     - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb'
     - 'lib/backup/manager.rb'
@@ -72,15 +79,19 @@ Style/RedundantInterpolation:
     - 'lib/gitlab/utils.rb'
     - 'lib/kramdown/converter/commonmark.rb'
     - 'lib/tasks/gettext.rake'
+    - 'lib/tasks/gitlab/seed/group_seed.rake'
+    - 'qa/qa/ee/page/component/secure_report.rb'
     - 'qa/qa/ee/page/merge_request/new.rb'
     - 'qa/qa/ee/page/project/issue/show.rb'
+    - 'qa/qa/ee/page/project/secure/vulnerability_details.rb'
     - 'qa/qa/resource/events/base.rb'
     - 'qa/qa/service/praefect_manager.rb'
     - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb'
     - 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb'
-    - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb'
+    - 'qa/qa/specs/features/ee/browser_ui/13_secure/scan_result_policy_vulnerabilities_spec.rb'
+    - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/project_templates_spec.rb'
+    - 'qa/qa/specs/features/ee/browser_ui/4_verify/parent_child_pipelines_dependent_relationship_spec.rb'
     - 'qa/qa/tools/generate_perf_testdata.rb'
-    - 'scripts/changed-feature-flags'
     - 'scripts/perf/gc/print_gc_stats.rb'
     - 'scripts/qa/testcases-check'
     - 'spec/controllers/admin/integrations_controller_spec.rb'
@@ -93,6 +104,7 @@ Style/RedundantInterpolation:
     - 'spec/features/projects/jobs/user_browses_jobs_spec.rb'
     - 'spec/graphql/resolvers/container_repositories_resolver_spec.rb'
     - 'spec/helpers/environments_helper_spec.rb'
+    - 'spec/helpers/snippets_helper_spec.rb'
     - 'spec/lib/api/helpers/packages/dependency_proxy_helpers_spec.rb'
     - 'spec/lib/api/validations/validators/git_ref_spec.rb'
     - 'spec/lib/api/validations/validators/limit_spec.rb'
@@ -116,7 +128,9 @@ Style/RedundantInterpolation:
     - 'spec/lib/gitlab/database/batch_count_spec.rb'
     - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb'
     - 'spec/lib/gitlab/import_export/group/tree_saver_spec.rb'
+    - 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb'
     - 'spec/lib/gitlab/metrics/dashboard/url_spec.rb'
+    - 'spec/lib/gitlab/redis/multi_store_spec.rb'
     - 'spec/lib/grafana/client_spec.rb'
     - 'spec/mailers/notify_spec.rb'
     - 'spec/migrations/20220107064845_populate_vulnerability_reads_spec.rb'
@@ -134,7 +148,6 @@ Style/RedundantInterpolation:
     - 'spec/requests/api/terraform/state_spec.rb'
     - 'spec/requests/projects/google_cloud/deployments_controller_spec.rb'
     - 'spec/requests/projects/google_cloud/service_accounts_controller_spec.rb'
-    - 'spec/requests/projects/google_cloud_controller_spec.rb'
     - 'spec/routing/project_routing_spec.rb'
     - 'spec/services/clusters/kubernetes/create_or_update_service_account_service_spec.rb'
     - 'spec/services/groups/transfer_service_spec.rb'