Identify masked variable output clearly
Masked variables being replaced with `[MASKED]` or with `xxxxxxx` depending on where the masking is happening is confusing (and currently neither(!) are explained in the docs). A masked variable has to be 8 characters or longer, which is exactly the length of `[MASKED]`. We can replace the first eight `x` in each masked variable on the Rails side with `[MASKED]` and have a slightly more consistent outcome for users.
显示
- config/feature_flags/gitlab_com_derisk/consistent_ci_variable_masking.yml 9 个添加, 0 个删除...lags/gitlab_com_derisk/consistent_ci_variable_masking.yml
- doc/ci/variables/index.md 5 个添加, 4 个删除doc/ci/variables/index.md
- lib/gitlab/ci/mask_secret.rb 15 个添加, 3 个删除lib/gitlab/ci/mask_secret.rb
- spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb 30 个添加, 3 个删除spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb
- spec/lib/gitlab/ci/config/external/file/artifact_spec.rb 43 个添加, 3 个删除spec/lib/gitlab/ci/config/external/file/artifact_spec.rb
- spec/lib/gitlab/ci/config/external/file/base_spec.rb 13 个添加, 1 个删除spec/lib/gitlab/ci/config/external/file/base_spec.rb
- spec/lib/gitlab/ci/config/external/file/local_spec.rb 15 个添加, 1 个删除spec/lib/gitlab/ci/config/external/file/local_spec.rb
- spec/lib/gitlab/ci/config/external/file/project_spec.rb 57 个添加, 6 个删除spec/lib/gitlab/ci/config/external/file/project_spec.rb
- spec/lib/gitlab/ci/config/external/file/remote_spec.rb 64 个添加, 6 个删除spec/lib/gitlab/ci/config/external/file/remote_spec.rb
- spec/lib/gitlab/ci/config/external/file/template_spec.rb 12 个添加, 1 个删除spec/lib/gitlab/ci/config/external/file/template_spec.rb
- spec/lib/gitlab/ci/config/external/mapper/matcher_spec.rb 14 个添加, 1 个删除spec/lib/gitlab/ci/config/external/mapper/matcher_spec.rb
- spec/lib/gitlab/ci/mask_secret_spec.rb 42 个添加, 7 个删除spec/lib/gitlab/ci/mask_secret_spec.rb
- spec/models/ci/build_spec.rb 18 个添加, 2 个删除spec/models/ci/build_spec.rb
- spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb 14 个添加, 1 个删除...ate_pipeline_service/creation_errors_and_warnings_spec.rb
加载中
想要评论请 注册 或 登录