Standardize path and lfs file locking syncing logic
When LFS files are locked, we create a PathLock, similarly, when a path is locked which is an LFS file, we create an LfsFileLock. Previously this logic was duplicated in the PathLock controller and the GraphQL mutation. This change moves the syncing logic into the services where it belongs. It also updates the LFS locking and unlocking services to ensure we don't have circular logic. When a path lock service calls an lfs service, we tell the lfs service not to create/destroy the path lock after creating/destroying the lfs file lock. Similarly, the lfs services do the same in the opposite direction. Related to https://gitlab.com/gitlab-org/gitlab/-/issues/512677
显示
- app/services/lfs/base_file_lock_service.rb 8 个添加, 0 个删除app/services/lfs/base_file_lock_service.rb
- app/services/lfs/lock_file_service.rb 1 个添加, 1 个删除app/services/lfs/lock_file_service.rb
- app/services/lfs/unlock_file_service.rb 1 个添加, 1 个删除app/services/lfs/unlock_file_service.rb
- ee/app/controllers/projects/path_locks_controller.rb 1 个添加, 14 个删除ee/app/controllers/projects/path_locks_controller.rb
- ee/app/graphql/mutations/projects/set_locked.rb 1 个添加, 9 个删除ee/app/graphql/mutations/projects/set_locked.rb
- ee/app/services/ee/lfs/base_file_lock_service.rb 25 个添加, 0 个删除ee/app/services/ee/lfs/base_file_lock_service.rb
- ee/app/services/ee/lfs/lock_file_service.rb 2 个添加, 8 个删除ee/app/services/ee/lfs/lock_file_service.rb
- ee/app/services/ee/lfs/unlock_file_service.rb 2 个添加, 8 个删除ee/app/services/ee/lfs/unlock_file_service.rb
- ee/app/services/path_locks/base_service.rb 31 个添加, 0 个删除ee/app/services/path_locks/base_service.rb
- ee/app/services/path_locks/lock_service.rb 9 个添加, 5 个删除ee/app/services/path_locks/lock_service.rb
- ee/app/services/path_locks/unlock_service.rb 13 个添加, 6 个删除ee/app/services/path_locks/unlock_service.rb
- ee/spec/services/lfs/lock_file_service_spec.rb 32 个添加, 25 个删除ee/spec/services/lfs/lock_file_service_spec.rb
- ee/spec/services/lfs/unlock_file_service_spec.rb 12 个添加, 9 个删除ee/spec/services/lfs/unlock_file_service_spec.rb
- ee/spec/services/path_locks/lock_service_spec.rb 57 个添加, 8 个删除ee/spec/services/path_locks/lock_service_spec.rb
- ee/spec/services/path_locks/unlock_service_spec.rb 60 个添加, 10 个删除ee/spec/services/path_locks/unlock_service_spec.rb
加载中
想要评论请 注册 或 登录