Merge branch 'handle-non-standard-severities-better-in-codequality-degradations' into 'master'

Handle non-standard severities better in codequality degradations

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143951



Merged-by: Ash McKenzie <amckenzie@gitlab.com>
Approved-by: Ash McKenzie <amckenzie@gitlab.com>
Reviewed-by: Ash McKenzie <amckenzie@gitlab.com>
Reviewed-by: Ahmed Hemdan <ahemdan@gitlab.com>
Co-authored-by: Ahmed Hemdan <ahemdan@gitlab.com>

app/serializers/codequality_degradation_entity.rb

@@ -4,7 +4,9 @@ class CodequalityDegradationEntity < Grape::Entity
   expose :description
   expose :fingerprint
   expose :severity do |degradation|
-    degradation.dig(:severity)&.downcase
+    severity = degradation.dig(:severity)&.downcase
+
+    ::Gitlab::Ci::Reports::CodequalityReports::SEVERITY_PRIORITIES.key?(severity) ? severity : 'unknown'
   end
 
   expose :file_path do |degradation|

spec/serializers/codequality_degradation_entity_spec.rb

@@ -54,6 +54,17 @@
           expect(subject[:engine_name]).to eq('rubocop')
         end
       end
+
+      context 'when severity is a non-codeclimate-standard severity' do
+        # See standard severities: https://docs.codeclimate.com/docs/issues#issue-severity
+        let(:codequality_degradation) { build(:codequality_degradation_3) }
+
+        it 'returns severity as unknown', :aggregate_failures do
+          codequality_degradation[:severity] = 'warning'
+
+          expect(subject[:severity]).to eq('unknown')
+        end
+      end
     end
   end
 end