Merge branch 'euko-fix-migration-spec' into 'master'

Fix "spec/migrations/swap_columns_for_system_note_metadata_id_spec.rb"

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142992



Merged-by: Krasimir Angelov <kangelov@gitlab.com>
Approved-by: Krasimir Angelov <kangelov@gitlab.com>
Co-authored-by: Eulyeon Ko <eko@gitlab.com>

spec/migrations/swap_columns_for_system_note_metadata_id_spec.rb

@@ -26,8 +26,8 @@
 
             primary_key_naming_check = query_constraint_by_name(:system_note_metadata, pk_name).first
             foreign_key_naming_check = query_constraint_by_name(:resource_link_events, fk_name).first
-            expect(primary_key_naming_check).to match("bool" => true)
-            expect(foreign_key_naming_check).to match("bool" => true)
+            expect(primary_key_naming_check).to match("constraint_exists" => true)
+            expect(foreign_key_naming_check).to match("constraint_exists" => true)
             expect(table.columns.find { |c| c.name == 'id' }.sql_type).to eq('integer')
             expect(table.columns.find { |c| c.name == 'id_convert_to_bigint' }.sql_type).to eq('bigint')
           }
@@ -37,8 +37,8 @@
 
             primary_key_naming_check = query_constraint_by_name(:system_note_metadata, pk_name).first
             foreign_key_naming_check = query_constraint_by_name(:resource_link_events, fk_name).first
-            expect(primary_key_naming_check).to match("bool" => true)
-            expect(foreign_key_naming_check).to match("bool" => true)
+            expect(primary_key_naming_check).to match("constraint_exists" => true)
+            expect(foreign_key_naming_check).to match("constraint_exists" => true)
             expect(table.columns.find { |c| c.name == 'id' }.sql_type).to eq('bigint')
             expect(table.columns.find { |c| c.name == 'id_convert_to_bigint' }.sql_type).to eq('integer')
           }
@@ -48,7 +48,7 @@
 
     def query_constraint_by_name(table_name, conname)
       described_class.new.connection.execute <<~SQL
-        SELECT true FROM pg_constraint c JOIN pg_class t ON t.oid = c.conrelid
+        SELECT true as constraint_exists FROM pg_constraint c JOIN pg_class t ON t.oid = c.conrelid
         WHERE t.relname = \'#{table_name}\' AND c.conname = \'#{conname}\';
       SQL
     end