Refactor `DeploymentUpdate` for readability
- Rename `Gitlab::Pages::DeploymentUpdate` to `Gitlab::Pages::DeploymentValidations` - Use `with_option` to avoid duplication - Remove some rubocop Todos - Refactor specs for clarity
显示
- .rubocop_todo/rspec/expect_in_hook.yml 0 个添加, 1 个删除.rubocop_todo/rspec/expect_in_hook.yml
- .rubocop_todo/rspec/feature_category.yml 0 个添加, 2 个删除.rubocop_todo/rspec/feature_category.yml
- .rubocop_todo/rspec/named_subject.yml 0 个添加, 1 个删除.rubocop_todo/rspec/named_subject.yml
- .rubocop_todo/style/guard_clause.yml 0 个添加, 1 个删除.rubocop_todo/style/guard_clause.yml
- .rubocop_todo/style/if_unless_modifier.yml 0 个添加, 1 个删除.rubocop_todo/style/if_unless_modifier.yml
- .rubocop_todo/style/inline_disable_annotation.yml 0 个添加, 2 个删除.rubocop_todo/style/inline_disable_annotation.yml
- .rubocop_todo/style/string_concatenation.yml 0 个添加, 1 个删除.rubocop_todo/style/string_concatenation.yml
- app/services/projects/update_pages_service.rb 6 个添加, 6 个删除app/services/projects/update_pages_service.rb
- ee/lib/ee/gitlab/pages/deployment_validations.rb 1 个添加, 1 个删除ee/lib/ee/gitlab/pages/deployment_validations.rb
- ee/spec/lib/ee/gitlab/pages/deployment_update_spec.rb 0 个添加, 82 个删除ee/spec/lib/ee/gitlab/pages/deployment_update_spec.rb
- ee/spec/lib/ee/gitlab/pages/deployment_validations_spec.rb 96 个添加, 0 个删除ee/spec/lib/ee/gitlab/pages/deployment_validations_spec.rb
- lib/gitlab/pages/deployment_validations.rb 40 个添加, 40 个删除lib/gitlab/pages/deployment_validations.rb
- spec/lib/gitlab/pages/deployment_validations_spec.rb 167 个添加, 0 个删除spec/lib/gitlab/pages/deployment_validations_spec.rb
- spec/support/rspec_order_todo.yml 0 个添加, 2 个删除spec/support/rspec_order_todo.yml
加载中
想要评论请 注册 或 登录