Skip to content
代码片段 群组 项目
未验证 提交 4f752efd 编辑于 作者: Thong Kuah's avatar Thong Kuah 提交者: GitLab
浏览文件

Merge branch 'add-guideline-url-rspec' into 'master'

Add guideline to use example urls

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/160370



Merged-by: default avatarThong Kuah <tkuah@gitlab.com>
Approved-by: default avatarThong Kuah <tkuah@gitlab.com>
Co-authored-by: default avatarAditya Tiwari <atiwari@gitlab.com>
No related branches found
No related tags found
无相关合并请求
...@@ -59,6 +59,7 @@ When using spring and guard together, use `SPRING=1 bundle exec guard` instead t ...@@ -59,6 +59,7 @@ When using spring and guard together, use `SPRING=1 bundle exec guard` instead t
- Try to follow the [Four-Phase Test](https://thoughtbot.com/blog/four-phase-test) pattern, using newlines - Try to follow the [Four-Phase Test](https://thoughtbot.com/blog/four-phase-test) pattern, using newlines
to separate phases. to separate phases.
- Use `Gitlab.config.gitlab.host` rather than hard coding `'localhost'`. - Use `Gitlab.config.gitlab.host` rather than hard coding `'localhost'`.
- For literal URLs in tests, use `example.com`, `gitlab.example.com`. This will ensure that we do not utilize any real URLs.
- Don't assert against the absolute value of a sequence-generated attribute (see - Don't assert against the absolute value of a sequence-generated attribute (see
[Gotchas](../gotchas.md#do-not-assert-against-the-absolute-value-of-a-sequence-generated-attribute)). [Gotchas](../gotchas.md#do-not-assert-against-the-absolute-value-of-a-sequence-generated-attribute)).
- Avoid using `expect_any_instance_of` or `allow_any_instance_of` (see - Avoid using `expect_any_instance_of` or `allow_any_instance_of` (see
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册