Merge branch 'ci-remove-includes-logging' into 'master'

Remove CI json.pipeline_includes_count logging

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/130374



Merged-by: Stan Hu <stanhu@gmail.com>
Approved-by: Stan Hu <stanhu@gmail.com>
Approved-by: Doug Stull <dstull@gitlab.com>
Approved-by: Siddharth Dungarwal <sdungarwal@gitlab.com>
Co-authored-by: lma-git <lma@gitlab.com>

app/services/ci/create_pipeline_service.rb

@@ -154,13 +154,6 @@ def build_logger
 
           duration >= LOG_MAX_CREATION_THRESHOLD
         end
-
-        l.log_when do |observations|
-          pipeline_includes_count = observations['pipeline_includes_count']
-          next false unless pipeline_includes_count
-
-          pipeline_includes_count.to_i > Gitlab::Ci::Config::External::Context::TEMP_MAX_INCLUDES
-        end
       end
     end
   end

lib/gitlab/ci/config/external/context.rb

@@ -9,8 +9,6 @@ class Context
 
           TimeoutError = Class.new(StandardError)
 
-          TEMP_MAX_INCLUDES = 100 # For logging; to be removed in https://gitlab.com/gitlab-org/gitlab/-/issues/396776
-
           include ::Gitlab::Utils::StrongMemoize
 
           attr_reader :project, :sha, :user, :parent_pipeline, :variables, :pipeline_config

lib/gitlab/ci/pipeline/chain/command.rb

@@ -128,10 +128,6 @@ def observe_jobs_count_in_alive_pipelines
               .observe({ plan: project.actual_plan_name }, jobs_count)
           end
 
-          def observe_pipeline_includes_count(pipeline)
-            logger.observe(:pipeline_includes_count, pipeline.config_metadata&.[](:includes)&.count, once: true)
-          end
-
           def increment_pipeline_failure_reason_counter(reason)
             metrics.pipeline_failure_reason_counter
               .increment(reason: (reason || :unknown_failure).to_s)

lib/gitlab/ci/pipeline/chain/sequence.rb

@@ -30,7 +30,6 @@ def build!
             @command.observe_creation_duration(current_monotonic_time - @start)
             @command.observe_pipeline_size(@pipeline)
             @command.observe_jobs_count_in_alive_pipelines
-            @command.observe_pipeline_includes_count(@pipeline)
 
             @pipeline
           end

spec/services/ci/create_pipeline_service/logger_spec.rb

@@ -139,74 +139,5 @@
         expect(pipeline).to be_created_successfully
       end
     end
-
-    describe 'pipeline includes count' do
-      before do
-        stub_const('Gitlab::Ci::Config::External::Context::TEMP_MAX_INCLUDES', 2)
-      end
-
-      context 'when the includes count exceeds the maximum' do
-        before do
-          allow_next_instance_of(Ci::Pipeline) do |pipeline|
-            allow(pipeline).to receive(:config_metadata)
-              .and_return({ includes: [{ file: 1 }, { file: 2 }, { file: 3 }] })
-          end
-        end
-
-        it 'creates a log entry' do
-          expect(Gitlab::AppJsonLogger)
-            .to receive(:info)
-            .with(a_hash_including({ 'pipeline_includes_count' => 3 }))
-            .and_call_original
-
-          expect(pipeline).to be_created_successfully
-        end
-      end
-
-      context 'when the includes count does not exceed the maximum' do
-        before do
-          allow_next_instance_of(Ci::Pipeline) do |pipeline|
-            allow(pipeline).to receive(:config_metadata)
-              .and_return({ includes: [{ file: 1 }, { file: 2 }] })
-          end
-        end
-
-        it 'does not create a log entry but it collects the data' do
-          expect(Gitlab::AppJsonLogger).not_to receive(:info)
-          expect(pipeline).to be_created_successfully
-
-          expect(service.logger.observations_hash)
-            .to match(a_hash_including({ 'pipeline_includes_count' => 2 }))
-        end
-      end
-
-      context 'when the includes data is nil' do
-        before do
-          allow_next_instance_of(Ci::Pipeline) do |pipeline|
-            allow(pipeline).to receive(:config_metadata)
-              .and_return({})
-          end
-        end
-
-        it 'does not create a log entry' do
-          expect(Gitlab::AppJsonLogger).not_to receive(:info)
-          expect(pipeline).to be_created_successfully
-        end
-      end
-
-      context 'when the pipeline config_metadata is nil' do
-        before do
-          allow_next_instance_of(Ci::Pipeline) do |pipeline|
-            allow(pipeline).to receive(:config_metadata)
-              .and_return(nil)
-          end
-        end
-
-        it 'does not create a log entry but it collects the data' do
-          expect(Gitlab::AppJsonLogger).not_to receive(:info)
-          expect(pipeline).to be_created_successfully
-        end
-      end
-    end
   end
 end