Skip to content
代码片段 群组 项目
未验证 提交 4af220ac 编辑于 作者: Phil Hughes's avatar Phil Hughes 提交者: GitLab
浏览文件

Merge branch 'slashmanov/fix-adding-discussions-to-rebased-mrs' into 'master'

Add a safeguard against non-matching diff discussion positions

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/144865



Merged-by: default avatarPhil Hughes <me@iamphill.com>
Approved-by: default avatarPhil Hughes <me@iamphill.com>
Co-authored-by: default avatarStanislav Lashmanov <slashmanov@gitlab.com>
No related branches found
No related tags found
无相关合并请求
......@@ -210,6 +210,8 @@ export default {
if (diffLines.length && positionType !== FILE_DIFF_POSITION_TYPE) {
const line = diffLines.find(isTargetLine);
// skip if none of the discussion positions matched a diff position
if (!line) return;
const discussions = addDiscussion(line.discussions || []);
Object.assign(line, {
discussions,
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册