Merge branch '495552-cleanup-events-cron-worker-retries' into 'master'

Cleanup CodeSuggestionEvents worker retries

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/175393



Merged-by: Adam Hegyi <ahegyi@gitlab.com>
Approved-by: Fabien Catteau <fcatteau@gitlab.com>
Approved-by: Schmil Monderer <smonderer@gitlab.com>
Approved-by: Jarka Košanová <jarka@gitlab.com>
Approved-by: Aaron Huntsman <ahuntsman@gitlab.com>
Approved-by: Adam Hegyi <ahegyi@gitlab.com>
Co-authored-by: Pavel Shutsin <pshutsin@gitlab.com>

db/migrate/20241211102605_cleanup_code_suggestion_events_retries.rb

+# frozen_string_literal: true
+
+class CleanupCodeSuggestionEventsRetries < Gitlab::Database::Migration[2.2]
+  disable_ddl_transaction!
+
+  milestone '17.7'
+
+  WORKER_CLASS = 'ClickHouse::CodeSuggestionEventsCronWorker'
+
+  def up
+    # TODO: make shard-aware. See https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/3430
+    Gitlab::SidekiqSharding::Validator.allow_unrouted_sidekiq_calls do
+      Sidekiq::Cron::Job.destroy('click_house_code_suggestion_events_cron_worker')
+    end
+
+    sidekiq_remove_jobs(job_klasses: [WORKER_CLASS])
+  end
+
+  def down
+    # no-op
+  end
+end

db/schema_migrations/20241211102605

+1fb92ff5ffe949e5eb24839c7d3a9a17ea3287decdf1627520779ae8ef811618
\ No newline at end of file

ee/app/workers/all_queues.yml

@@ -138,6 +138,15 @@
   :weight: 1
   :idempotent: true
   :tags: []
+- :name: cronjob:click_house_code_suggestion_events_cron
+  :worker_name: ClickHouse::CodeSuggestionEventsCronWorker
+  :feature_category: :database
+  :has_external_dependencies: false
+  :urgency: :low
+  :resource_boundary: :unknown
+  :weight: 1
+  :idempotent: true
+  :tags: []
 - :name: cronjob:click_house_dump_all_write_buffers_cron
   :worker_name: ClickHouse::DumpAllWriteBuffersCronWorker
   :feature_category: :database

ee/app/workers/click_house/code_suggestion_events_cron_worker.rb

+# frozen_string_literal: true
+
+module ClickHouse # rubocop:disable Gitlab/BoundedContexts -- this file will be removed in next release.
+  # Alias worker class. Remove after 17.8 release so scheduled cron jobs can work-off properly
+  class CodeSuggestionEventsCronWorker < DumpAllWriteBuffersCronWorker
+    idempotent!
+
+    def perform
+      # no-op
+    end
+  end
+end