Merge branch 'fix/500-on-viewing-group-analytics' into 'master'

Fix broken schema path on group analytics dashboard

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/157228



Merged-by: Ethan Urie <eurie@gitlab.com>
Approved-by: Sam Figueroa <sfigueroa@gitlab.com>
Approved-by: Ethan Urie <eurie@gitlab.com>
Reviewed-by: Ethan Urie <eurie@gitlab.com>
Co-authored-by: Anton Smith <asmith@gitlab.com>

ee/app/models/concerns/product_analytics/schema_validator.rb

@@ -3,7 +3,7 @@
 module ProductAnalytics
   module SchemaValidator
     def schema_errors_for(yaml)
-      validator = JSONSchemer.schema(Pathname.new(self.class::SCHEMA_PATH))
+      validator = JSONSchemer.schema(Pathname.new(Rails.root.join(self.class::SCHEMA_PATH)))
       validator_errors = validator.validate(yaml)
       validator_errors.map { |e| JSONSchemer::Errors.pretty(e) } if validator_errors.any?
     end

ee/spec/models/product_analytics/visualization_spec.rb

@@ -47,6 +47,17 @@
     end
   end
 
+  describe '#schema_errors_for' do
+    let(:dashboard) { dashboards.find { |d| d.title == 'Audience' } }
+
+    it 'fetches correct schema path' do
+      allow(JSONSchemer).to receive(:schema).and_call_original
+      expect(JSONSchemer).to receive(:schema).with(Rails.root.join(described_class::SCHEMA_PATH))
+
+      dashboard.panels.first.visualization
+    end
+  end
+
   describe '.for' do
     context 'when resource_parent is a Project' do
       subject { described_class.for(container: project, user: user) }