Merge branch '349267_support_paretheses_for_issue_templates' into 'master'

Allow parentheses for template names

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/138367



Merged-by: Roy Zwambag <rzwambag@gitlab.com>
Approved-by: Roy Zwambag <rzwambag@gitlab.com>
Approved-by: Aakriti Gupta <agupta@gitlab.com>
Co-authored-by: Vasilii Iakliushin <viakliushin@gitlab.com>

lib/api/project_templates.rb

@@ -8,7 +8,7 @@ class ProjectTemplates < ::API::Base
     # The regex is needed to ensure a period (e.g. agpl-3.0)
     # isn't confused with a format type. We also need to allow encoded
     # values (e.g. C%2B%2B for C++), so allow % and + as well.
-    TEMPLATE_NAMES_ENDPOINT_REQUIREMENTS = API::NAMESPACE_OR_PROJECT_REQUIREMENTS.merge(name: /[\w%.+-]+/)
+    TEMPLATE_NAMES_ENDPOINT_REQUIREMENTS = API::NAMESPACE_OR_PROJECT_REQUIREMENTS.merge(name: /[\w()%.+-]+/)
 
     before { authenticate_non_get! }
 

spec/factories/projects.rb

@@ -342,6 +342,12 @@
             'something valid',
             message: 'test 3',
             branch_name: 'master')
+          project.repository.create_file(
+            project.creator,
+            ".gitlab/#{templates_path}/(test).md",
+            'parentheses',
+            message: 'test 3',
+            branch_name: 'master')
           project.repository.create_file(
             project.creator,
             ".gitlab/#{templates_path}/template_test.md",

spec/requests/api/project_templates_spec.rb

@@ -69,7 +69,7 @@
       expect(response).to have_gitlab_http_status(:ok)
       expect(response).to include_pagination_headers
       expect(response).to match_response_schema('public_api/v4/template_list')
-      expect(json_response.map { |t| t['key'] }).to match_array(%w[bug feature_proposal template_test])
+      expect(json_response.map { |t| t['key'] }).to match_array(%w[bug feature_proposal template_test (test)])
     end
 
     it 'returns merge request templates' do
@@ -78,7 +78,7 @@
       expect(response).to have_gitlab_http_status(:ok)
       expect(response).to include_pagination_headers
       expect(response).to match_response_schema('public_api/v4/template_list')
-      expect(json_response.map { |t| t['key'] }).to match_array(%w[bug feature_proposal template_test])
+      expect(json_response.map { |t| t['key'] }).to match_array(%w[bug feature_proposal template_test (test)])
     end
 
     it 'returns 400 for an unknown template type' do
@@ -171,6 +171,17 @@
       expect(json_response['content']).to eq('something valid')
     end
 
+    context 'when issue template uses parentheses' do
+      it 'returns a specific issue template' do
+        get api("/projects/#{private_project.id}/templates/issues/(test)", developer)
+
+        expect(response).to have_gitlab_http_status(:ok)
+        expect(response).to match_response_schema('public_api/v4/template')
+        expect(json_response['name']).to eq('(test)')
+        expect(json_response['content']).to eq('parentheses')
+      end
+    end
+
     it 'returns a specific merge request template' do
       get api("/projects/#{public_project.id}/templates/merge_requests/feature_proposal")