Add `PagesDeployment` upload_finished field
Before [serving pages directly from pages_deployments], we were creating an `PagesDeployment` and in the commit callback, the ZIP file was uploaded. Only after the `PagesDeployment` entry was committed to the database, we would update the `ProjectPagesMetadatum` to indicate the deployment was ready. Now, [serving pages directly from pages_deployments], created a problem where we're starting to serve a `PagesDeployment` before its upload is ready. To fix that, a new `upload_ready` column will be introduced, to signalize when the new `PagesDeployment` upload is finished and we start to serve it. [serving pages directly from pages_deployments]: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/135993 Changelog: fixed
显示
- app/models/pages_deployment.rb 21 个添加, 1 个删除app/models/pages_deployment.rb
- app/services/projects/update_pages_service.rb 2 个添加, 1 个删除app/services/projects/update_pages_service.rb
- db/migrate/20231115091119_add_upload_finished_to_pages_deployments.rb 14 个添加, 0 个删除...0231115091119_add_upload_finished_to_pages_deployments.rb
- db/post_migrate/20231115151449_update_pages_deployments_upload_ready_default_value.rb 13 个添加, 0 个删除...49_update_pages_deployments_upload_ready_default_value.rb
- db/schema_migrations/20231115091119 1 个添加, 0 个删除db/schema_migrations/20231115091119
- db/schema_migrations/20231115151449 1 个添加, 0 个删除db/schema_migrations/20231115151449
- db/structure.sql 1 个添加, 0 个删除db/structure.sql
- spec/models/pages_deployment_spec.rb 10 个添加, 0 个删除spec/models/pages_deployment_spec.rb
- spec/uploaders/pages/deployment_uploader_spec.rb 21 个添加, 18 个删除spec/uploaders/pages/deployment_uploader_spec.rb
加载中
想要评论请 注册 或 登录