Merge branch '513365-fix-before-sha-in-pipeline-execution-policy' into 'master'

Include before_sha in PEP pipelines

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/182876



Merged-by: Furkan Ayhan <furkanayhn@gmail.com>
Approved-by: Martin Čavoj <mcavoj@gitlab.com>
Approved-by: Furkan Ayhan <furkanayhn@gmail.com>
Reviewed-by: Furkan Ayhan <furkanayhn@gmail.com>
Reviewed-by: Martin Čavoj <mcavoj@gitlab.com>
Co-authored-by: Andy Schoenen <aschoenen@gitlab.com>

ee/lib/gitlab/ci/pipeline/pipeline_execution_policies/pipeline_context.rb

@@ -130,6 +130,8 @@ def create_pipeline(policy, partition_id)
               ::Ci::CreatePipelineService
                 .new(project, command.current_user,
                   ref: command.ref,
+                  before: command.before_sha,
+                  after: command.after_sha,
                   source_sha: command.source_sha,
                   checkout_sha: command.checkout_sha,
                   target_sha: command.target_sha,

ee/spec/lib/gitlab/ci/pipeline/pipeline_execution_policies/pipeline_context_spec.rb

@@ -70,6 +70,17 @@
       end
     end
 
+    it 'passes the right shas to the pipeline' do
+      perform
+
+      context.policy_pipelines.each do |policy_pipeline|
+        expect(policy_pipeline.pipeline.ref).to eq(pipeline.ref)
+        expect(policy_pipeline.pipeline.before_sha).to eq(pipeline.before_sha)
+        expect(policy_pipeline.pipeline.source_sha).to eq(pipeline.source_sha)
+        expect(policy_pipeline.pipeline.target_sha).to eq(pipeline.target_sha)
+      end
+    end
+
     it 'propagates partition_id to policy pipelines' do
       perform
 

ee/spec/services/ci/create_pipeline_service/pipeline_execution_policy_spec.rb

@@ -315,6 +315,72 @@
     end
   end
 
+  context 'with jobs using rules:changes' do
+    let(:project_policy_content) do
+      {
+        project_policy_job: {
+          stage: 'test',
+          script: 'project script',
+          rules: [
+            {
+              changes: [
+                'development.txt'
+              ]
+            }
+          ]
+        }
+      }
+    end
+
+    it 'includes the job' do
+      builds = execute.payload.builds
+
+      expect(builds.map(&:name)).to include('project_policy_job')
+    end
+
+    context 'when a file is touched in a commit' do
+      before_all do
+        group.add_owner(user)
+      end
+
+      let(:before_sha) { project.repository.commit.sha }
+      let(:opts) do
+        { origin_ref: project.default_branch_or_main, before_sha: before_sha, source_sha: before_sha,
+          target_sha: new_sha }
+      end
+
+      let(:new_sha) do
+        create_file_in_repo(
+          project,
+          project.default_branch_or_main,
+          project.default_branch_or_main,
+          touched_tile_name, 'This is a test',
+          commit_message: 'Touch file'
+        )[:result]
+      end
+
+      context 'when the file listed in changes is not touched' do
+        let(:touched_tile_name) { 'production.txt' }
+
+        it 'does not include the job' do
+          builds = execute.payload.builds
+
+          expect(builds.map(&:name)).not_to include('project_policy_job')
+        end
+      end
+
+      context 'when the file listed in changes is touched' do
+        let(:touched_tile_name) { 'development.txt' }
+
+        it 'includes the job' do
+          builds = execute.payload.builds
+
+          expect(builds.map(&:name)).to include('project_policy_job')
+        end
+      end
+    end
+  end
+
   context 'when any policy contains `override_project_ci` strategy' do
     let(:project_policy) do
       build(:pipeline_execution_policy, :override_project_ci,