Merge branch 'pl-spec-flaky-vuln-reads-finder' into 'master'

Fix flaky spec vulnerability reads finder spec

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/150090



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

ee/spec/finders/security/vulnerability_reads_finder_spec.rb

@@ -180,12 +180,9 @@
     let!(:another_vulnerability) { create(:vulnerability, :with_finding, project: another_project) }
 
     let_it_be(:group) { create(:group) }
+    let_it_be(:project) { create(:project, namespace: group) }
     let_it_be(:archived_project) { create(:project, :archived, namespace: group) }
 
-    before do
-      project.update!(namespace: group)
-    end
-
     context 'when filtered by project' do
       let!(:archived_vulnerability) { create(:vulnerability, :with_findings, project: archived_project) }
       let(:filters) { { project_id: [another_project.id, archived_project.id] } }

spec/support/rspec_order_todo.yml

@@ -511,7 +511,6 @@
 - './ee/spec/finders/security/scan_execution_policies_finder_spec.rb'
 - './ee/spec/finders/security/vulnerabilities_finder_spec.rb'
 - './ee/spec/finders/security/vulnerability_feedbacks_finder_spec.rb'
-- './ee/spec/finders/security/vulnerability_reads_finder_spec.rb'
 - './ee/spec/finders/snippets_finder_spec.rb'
 - './ee/spec/finders/template_finder_spec.rb'
 - './ee/spec/finders/users_finder_spec.rb'