Merge branch 'el-reset-sms-send-data' into 'master'

Set sms_send_count to 1 if last SMS was sent before the current day

Closes gitlab-org/modelops/anti-abuse/team-tasks#573

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142094



Merged-by: Roy Zwambag <rzwambag@gitlab.com>
Approved-by: Roy Zwambag <rzwambag@gitlab.com>
Approved-by: Alex Buijs <abuijs@gitlab.com>
Reviewed-by: Alex Buijs <abuijs@gitlab.com>
Co-authored-by: Eugie Limpin <elimpin@gitlab.com>

ee/app/services/phone_verification/users/send_verification_code_service.rb

@@ -174,9 +174,12 @@ def success(risk_result, send_code_result)
         attrs = { telesign_reference_xid: send_code_result[:telesign_reference_xid] }
 
         if Feature.enabled?(:sms_send_wait_time, user)
+          last_sms_sent_today = record.sms_sent_at&.today?
+          sms_send_count = last_sms_sent_today ? record.sms_send_count + 1 : 1
+
           attrs.merge!({
             sms_sent_at: Time.current,
-            sms_send_count: record.sms_send_count + 1
+            sms_send_count: sms_send_count
           })
         end
 

ee/spec/services/phone_verification/users/send_verification_code_service_spec.rb

@@ -365,6 +365,17 @@
         expect(record.sms_sent_at).to eq(Time.current)
       end
 
+      context 'when last SMS was sent before the current day' do
+        before do
+          create(:phone_number_validation, user: user, sms_sent_at: 1.day.ago, sms_send_count: 2)
+        end
+
+        it 'sets sms_send_count to 1' do
+          record = user.phone_number_validation
+          expect { service.execute }.to change { record.reload.sms_send_count }.from(2).to(1)
+        end
+      end
+
       context 'when sms_send_wait_time feature flag is disabled' do
         before do
           stub_feature_flags(sms_send_wait_time: false)