Merge branch '422264-remove-browsersdk_tracking-ff' into 'master'

Remove browsersdk_tracking feature flag

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/141212



Merged-by: Lin Jen-Shin <jen-shin@gitlab.com>
Approved-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Approved-by: Lin Jen-Shin <jen-shin@gitlab.com>
Reviewed-by: Michael Becker <11881043-wandering_person@users.noreply.gitlab.com>
Co-authored-by: Ankit <apanchal@gitlab.com>

app/views/layouts/_snowplow.html.haml

@@ -2,7 +2,7 @@
 
 - namespace = @group || @project&.namespace || @namespace
 = webpack_bundle_tag 'tracker'
-- if Gitlab.com? && Feature.enabled?(:browsersdk_tracking) && Feature.enabled?(:gl_analytics_tracking, Feature.current_request)
+- if Gitlab.com? && Feature.enabled?(:gl_analytics_tracking, Feature.current_request)
   = webpack_bundle_tag 'analytics'
 = javascript_tag do
   :plain

config/feature_flags/development/browsersdk_tracking.yml

----
-name: browsersdk_tracking
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/129517
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/422264
-milestone: '16.4'
-type: development
-group: group::analytics instrumentation
-default_enabled: false

lib/gitlab/gon_helper.rb

@@ -123,7 +123,7 @@ def default_avatar_url
     end
 
     def add_browsersdk_tracking
-      return unless Gitlab.com? && Feature.enabled?(:browsersdk_tracking) && Feature.enabled?(:gl_analytics_tracking,
+      return unless Gitlab.com? && Feature.enabled?(:gl_analytics_tracking,
 Feature.current_request)
 
       return if ENV['GITLAB_ANALYTICS_URL'].blank? || ENV['GITLAB_ANALYTICS_ID'].blank?

spec/lib/gitlab/gon_helper_spec.rb

@@ -205,7 +205,6 @@
 
       context 'when feature flag is false' do
         before do
-          stub_feature_flags(browsersdk_tracking: false)
           stub_feature_flags(gl_analytics_tracking: false)
         end