Merge branch 'da-remove-editor-field-from-workspaces-table' into 'master'

Drop the editor field from the workspaces table

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/167823



Merged-by: Michał Zając <mzajac@gitlab.com>
Approved-by: Michał Zając <mzajac@gitlab.com>
Reviewed-by: Max Woolf <mwoolf@gitlab.com>
Co-authored-by: Daniyal Arshad <darshad@gitlab.com>

db/post_migrate/20241001185217_remove_workspaces_editor_column.rb

+# frozen_string_literal: true
+
+class RemoveWorkspacesEditorColumn < Gitlab::Database::Migration[2.2]
+  milestone '17.6'
+
+  def up
+    remove_column :workspaces, :editor
+  end
+
+  def down
+    add_column :workspaces, :editor, :text, limit: 256, default: 'webide', null: false
+  end
+end

db/schema_migrations/20241001185217

+2f9540b1e1a298b20bcc5a6a284e293b5ec62cba0c851d33815c5e1cc48d6143
\ No newline at end of file

db/structure.sql

@@ -21305,7 +21305,6 @@ CREATE TABLE workspaces (
     namespace text NOT NULL,
     desired_state text NOT NULL,
     actual_state text NOT NULL,
-    editor text DEFAULT 'webide'::text NOT NULL,
     devfile_ref text NOT NULL,
     devfile_path text NOT NULL,
     devfile text,
@@ -21328,7 +21327,6 @@ CREATE TABLE workspaces (
     CONSTRAINT check_8e4db5ffc2 CHECK ((char_length(actual_state) <= 32)),
     CONSTRAINT check_9e42558c35 CHECK ((char_length(url) <= 1024)),
     CONSTRAINT check_b70eddcbc1 CHECK ((char_length(desired_state) <= 32)),
-    CONSTRAINT check_d7ed376e49 CHECK ((char_length(editor) <= 256)),
     CONSTRAINT check_dc58d56169 CHECK ((char_length(devfile_path) <= 2048)),
     CONSTRAINT check_eb32879a3d CHECK ((char_length(devfile) <= 65535)),
     CONSTRAINT check_ffa8cad434 CHECK ((char_length(url_prefix) <= 256))