Skip to content
代码片段 群组 项目
提交 38e1027a 编辑于 作者: Joe Woodward's avatar Joe Woodward 提交者: Joe Woodward
浏览文件

Add `destroy` to bulk_database_action dangerbot suggestions

We already check if the code includes `danger` but the suggestion
comment did not include it which can lead to confusion.
上级 ea98b0eb
No related branches found
No related tags found
无相关合并请求
......@@ -56,6 +56,7 @@
'upsert_all',
'User.upsert',
'User.last.destroy',
'destroy',
' .destroy'
]
end
......
......@@ -10,11 +10,13 @@ class BulkDatabaseActions < Suggestion
DOCUMENTATION_LINK = 'https://docs.gitlab.com/ee/development/database_review.html#preparation-when-using-bulk-update-operations'
SUGGESTION = <<~MESSAGE_MARKDOWN.freeze
When using `update`, `upsert`, `delete`, `update_all`, `upsert_all`, `delete_all` or `destroy_all`
you must include the full database query and query execution plan in the merge request description,
and request a ~database review.
When using `update`, `upsert`, `delete`, `destroy`, `update_all`,
`upsert_all`, `delete_all` or `destroy_all` you must include the full
database query and query execution plan in the merge request
description, and request a ~database review.
This comment can be ignored if the object is not an ActiveRecord class, since no database query would be generated.
This comment can be ignored if the object is not an ActiveRecord class,
since no database query would be generated.
----
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册