Mark 20240119130539 as obsolete

This migration marks the 20240119130539 ReindexNotesToUpdateAnalyzer Advanced search migration as obsolete.

[Search for references to `reindex_notes_to_update_analyzer` in code](https://gitlab.com/search?project_id=278964&scope=blobs&search=reindex_notes_to_update_analyzer&regex=false))

At the moment, the `gitlab-housekeeper` is not always capable of removing all references so
you must check the diff and pipeline failures to confirm if there are any issues.
It is the responsibility of the assignee (picked from ~"group::global search") to push those changes to this branch.

[Read more](https://docs.gitlab.com/ee/development/search/advanced_search_migration_styleguide.html#cleaning-up-advanced-search-migrations)
about the process for marking Advanced search migrations as obsolete.

All Advanced search migrations must have had at least one
[required stop](https : // docs.gitlab.com / ee / development / database / required_stops.html)
to process the migration. Therefore we mark any Advanced search migrations added before the
last required stop as obsolete.

This change was generated by
[gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper)
using the Keeps::MarkOldAdvancedSearchMigrationsAsObsolete keep.

To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the
label ~"GitLab Housekeeper" and consider pinging the author of this keep.

Changelog: other
EE: true

ee/elastic/docs/20240119130539_reindex_notes_to_update_analyzer.yml

 ---
 name: ReindexNotesToUpdateAnalyzer
 version: '20240119130539'
-description: This migration reindexes the notes index to start using new analyzer for notes.note
+description: This migration reindexes the notes index to start using new analyzer
+  for notes.note
 group: group::global search
 milestone: '16.9'
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/142301
-obsolete: false
-marked_obsolete_by_url:
-marked_obsolete_in_milestone:
+obsolete: true
+marked_obsolete_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169299
+marked_obsolete_in_milestone: '17.6'

ee/elastic/migrate/20240119130539_reindex_notes_to_update_analyzer.rb

@@ -9,3 +9,5 @@ def completed?
     true
   end
 end
+
+ReindexNotesToUpdateAnalyzer.prepend ::Elastic::MigrationObsolete

ee/spec/elastic/migrate/20240119130539_reindex_notes_to_update_analyzer_spec.rb

@@ -4,26 +4,5 @@
 require File.expand_path('ee/elastic/migrate/20240119130539_reindex_notes_to_update_analyzer.rb')
 
 RSpec.describe ReindexNotesToUpdateAnalyzer, feature_category: :global_search do
-  let(:version) { 20240119130539 }
-  let(:migration) { described_class.new(version) }
-
-  it 'does not have migration options set', :aggregate_failures do
-    expect(migration).not_to be_batched
-    expect(migration).not_to be_retry_on_failure
-  end
-
-  describe '#migrate' do
-    it 'creates reindexing task with correct target and options' do
-      expect { migration.migrate }.to change { Elastic::ReindexingTask.count }.by(1)
-      task = Elastic::ReindexingTask.last
-      expect(task.targets).to eq(%w[Note])
-      expect(task.options).to eq({ 'skip_pending_migrations_check' => true })
-    end
-  end
-
-  describe '#completed?' do
-    it 'always returns true' do
-      expect(migration.completed?).to eq(true)
-    end
-  end
+  it_behaves_like 'a deprecated Advanced Search migration', 20240119130539
 end