Merge branch 's_de/fix/da_48-lp-circular-deps-cache' into 'master'

Default to metadata cache for dependency-cruiser and disable cache on CI

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/184319



Merged-by: Kev Kloss <kkloss@gitlab.com>
Approved-by: Kev Kloss <kkloss@gitlab.com>
Reviewed-by: Kev Kloss <kkloss@gitlab.com>
Co-authored-by: Lohit Peesapati <lpeesapati@gitlab.com>

config/dependency_cruiser.js

@@ -72,9 +72,9 @@ module.exports = {
       fileName: './config/webpack.config.js',
     },
     cache: {
-      // Use Yarn's cache directory
       folder: './tmp/cache/depcruise-cache',
-      strategy: 'content',
+      // NOTE: if we want to store cache on CI, set the value to 'content'
+      strategy: 'metadata',
       // With compression the cache is around 2MB
       // Without Compression, cache is 20 times larger
       compress: true,

scripts/frontend/eslint.js

@@ -7,7 +7,7 @@ To see the full list of circular dependencies, run the command ${chalk.bold.cyan
 If you have fixed existing circular dependencies or find false positives, you can add/remove them from the
 exclusions list in the 'config/dependency-cruiser.js' file.\n
 ${chalk.italic('If the above command fails because of memory issues, increase the memory by prepending it with the following')}
-${chalk.bold.cyan('NODE_OPTIONS="--max_old_space_size=4096"')}
+${chalk.bold.cyan('NODE_OPTIONS="--max-old-space-size=4096"')}
 `);
 };
 

scripts/static-analysis

@@ -51,7 +51,7 @@ class StaticAnalysis
     Task.new(%w[scripts/lint-vendored-gems.sh], 10),
     Task.new(%w[yarn run check-dependencies], 1),
     Task.new(%w[scripts/gemfile_lock_changed.sh], 1),
-    Task.new(%w[yarn run deps:check:all], 60)
+    Task.new(%w[yarn run deps:check:all --no-cache], 60)
   ].compact.freeze
 
   def run_tasks!(options = {})