Merge branch 'if-430753-features_admin_user_spec_improvements' into 'master'

Improvements to admin/users feature specs

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/140218



Merged-by: Drew Blessing <drew@gitlab.com>
Approved-by: Smriti Garg <sgarg@gitlab.com>
Approved-by: Drew Blessing <drew@gitlab.com>
Co-authored-by: Imre Farkas <ifarkas@gitlab.com>

spec/features/admin/users/admin_impersonates_user_spec.rb

@@ -53,7 +53,7 @@
           it 'does not show impersonate button for admin itself' do
             subject
 
-            expect(page).not_to have_content('Impersonate')
+            expect(page).to have_no_content('Impersonate')
           end
         end
 
@@ -66,7 +66,7 @@
         end
 
         context 'for user with expired password' do
-          let(:user_to_visit) do
+          let_it_be(:user_to_visit) do
             another_user.update!(password_expires_at: Time.zone.now - 5.minutes)
             another_user
           end
@@ -113,7 +113,7 @@
           it 'does not show impersonate button' do
             subject
 
-            expect(page).not_to have_content('Impersonate')
+            expect(page).to have_no_content('Impersonate')
           end
         end
       end
@@ -145,7 +145,6 @@
 
           let_it_be(:another_user) { create(:user, :unconfirmed) }
           let(:warning_alert) { page.find(:css, '[data-testid="alert-warning"]') }
-          let(:expected_styling) { { 'pointer-events' => 'none', 'cursor' => 'default' } }
 
           context 'with an email that does not contain HTML' do
             before do

spec/features/admin/users/admin_manages_user_identities_spec.rb

@@ -16,8 +16,10 @@
       it 'shows user identities', :aggregate_failures do
         visit admin_user_identities_path(user)
 
-        expect(page).to have_content(user.name)
-        expect(page).to have_content('twitter')
+        expect(page).to(
+          have_content(user.name)
+            .and(have_content('twitter'))
+        )
       end
     end