Merge branch '282479-add-spec-for-missing-methods-vulnerability-presenter' into 'master'

Add specs for links & location_text

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/127928



Merged-by: Nicolas Dular <ndular@gitlab.com>
Approved-by: Bojan Marjanovic <bmarjanovic@gitlab.com>
Approved-by: Sam Figueroa <sfigueroa@gitlab.com>
Approved-by: Nicolas Dular <ndular@gitlab.com>
Reviewed-by: Thiago Figueiró <tfigueiro@gitlab.com>
Co-authored-by: bymayanksingh <mayank.singh081997@gmail.com>

ee/spec/presenters/vulnerability_presenter_spec.rb

@@ -13,8 +13,27 @@
 
   let_it_be(:finding2) { create(:vulnerabilities_finding, :with_secret_detection, scan: sast_scan) }
 
+  let_it_be(:vulnerability_links) do
+    [
+      { name: 'link1', url: 'www.example.com/link1' },
+      { name: 'link2', url: 'www.exampple.com/link2' }
+    ]
+  end
+
   subject  { described_class.new(finding.vulnerability) }
 
+  describe '#links' do
+    context 'when vulnerability has links' do
+      before do
+        allow(finding.vulnerability).to receive(:links).and_return(vulnerability_links)
+      end
+
+      it 'expect links to be instance of active support hash with indifferent access' do
+        expect(subject.links).to all(be_a(ActiveSupport::HashWithIndifferentAccess))
+      end
+    end
+  end
+
   describe '#scanner' do
     it 'returns the scanner for a finding' do
       expect(subject.scanner).to eql(finding.scanner)
@@ -47,6 +66,22 @@
     end
   end
 
+  describe '#location_text' do
+    context 'when line is nil' do
+      it 'returns a string with file' do
+        allow(subject).to receive(:line).and_return(nil)
+
+        expect(subject.location_text).to eq finding.file
+      end
+    end
+
+    context 'when line is present' do
+      it 'returns a string with file and line' do
+        expect(subject.location_text).to eq "#{finding.file}:#{finding.location['start_line']}"
+      end
+    end
+  end
+
   describe '#location_link_with_raw_path' do
     context 'when the end_line is the same as the start_line' do
       it 'returns the location link in raw format' do