Skip to content
代码片段 群组 项目
提交 2fe75a7a 编辑于 作者: Miguel Rincon's avatar Miguel Rincon
浏览文件

Use correct label for 50th percentile in charts

P50 represents the median, not the mean, this
fixes a misleading label in the pipeline duration
charts.
上级 ae2dae89
No related branches found
No related tags found
2 合并请求!3031Merge per-main-jh to main-jh by luzhiyuan,!3030Merge per-main-jh to main-jh
......@@ -75,7 +75,7 @@ export default {
this.pipelineAnalytics.aggregate;
return {
total: count === null ? '-' : count,
meanDuration: durationStatistics.p50,
medianDuration: durationStatistics.p50,
successRatio: Number(count) ? (successCount / count) * 100 : 0,
failureRatio: Number(count) ? (failedCount / count) * 100 : 0,
};
......
......@@ -25,7 +25,7 @@ export default {
computed: {
data() {
const durationSeries = [
{ name: s__('Pipeline|Mean (50th percentile)'), data: [] },
{ name: s__('Pipeline|Median (50th percentile)'), data: [] },
{ name: s__('Pipeline|95th percentile'), data: [] },
];
......
......@@ -52,11 +52,11 @@ export default {
},
];
if (this.counts.meanDuration) {
if (this.counts.medianDuration) {
statistics.splice(1, 0, {
label: s__('PipelineCharts|Mean duration'),
identifier: 'mean-duration',
value: formatTimeSpent(this.counts.meanDuration),
label: s__('PipelineCharts|Median duration'),
identifier: 'median-duration',
value: formatTimeSpent(this.counts.medianDuration),
});
}
......
......@@ -42477,7 +42477,7 @@ msgstr ""
msgid "PipelineCharts|Last week"
msgstr ""
 
msgid "PipelineCharts|Mean duration"
msgid "PipelineCharts|Median duration"
msgstr ""
 
msgid "PipelineCharts|Pipelines"
......@@ -43389,7 +43389,7 @@ msgstr ""
msgid "Pipeline|Manual"
msgstr ""
 
msgid "Pipeline|Mean (50th percentile)"
msgid "Pipeline|Median (50th percentile)"
msgstr ""
 
msgid "Pipeline|Merge request pipeline"
......@@ -104,7 +104,7 @@ describe('~/projects/pipelines/charts/components/pipeline_charts_new.vue', () =>
expect(findStatisticsList().props('counts')).toEqual({
failureRatio: 0,
meanDuration: 0,
medianDuration: 0,
successRatio: 0,
total: '0',
});
......@@ -123,13 +123,13 @@ describe('~/projects/pipelines/charts/components/pipeline_charts_new.vue', () =>
expect(findStatisticsList().props('counts')).toEqual({
failureRatio: 25,
meanDuration: 1800,
medianDuration: 1800,
successRatio: 25,
total: '8',
});
expect(findAllSingleStats().at(0).text()).toBe('Total pipeline runs 8');
expect(findAllSingleStats().at(1).text()).toBe('Mean duration 30m');
expect(findAllSingleStats().at(1).text()).toBe('Median duration 30m');
expect(findAllSingleStats().at(2).text()).toBe('Failure rate 25%');
expect(findAllSingleStats().at(3).text()).toBe('Success rate 25%');
});
......
......@@ -44,7 +44,7 @@ describe('PipelineDurationChart', () => {
},
},
data: [
{ data: [], name: 'Mean (50th percentile)' },
{ data: [], name: 'Median (50th percentile)' },
{ data: [], name: '95th percentile' },
],
});
......@@ -66,7 +66,7 @@ describe('PipelineDurationChart', () => {
['2021-12-01', 100],
['2021-12-02', 101],
],
name: 'Mean (50th percentile)',
name: 'Median (50th percentile)',
},
{
data: [
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册