Merge branch...

Merge branch '493768--add-not-null-constraint-sharding-key-vulnerability_state_transitions' into 'master' 

Add NOT NULL on sharding key for vulnerability_state_transitions

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/182698



Merged-by: Leonardo da Rosa <ldarosa@gitlab.com>
Approved-by: Shubham Kumar <shukumar@gitlab.com>
Approved-by: Leonardo da Rosa <ldarosa@gitlab.com>
Reviewed-by: Leonardo da Rosa <ldarosa@gitlab.com>
Co-authored-by: Shane Maglangit <smaglangit@gitlab.com>

db/docs/vulnerability_state_transitions.yml

@@ -12,14 +12,6 @@ schema_inconsistencies:
 - type: missing_indexes
   object_name: index_vulnerability_state_transitions_resolved_activity
   introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/176561
-desired_sharding_key:
-  project_id:
-    references: projects
-    backfill_via:
-      parent:
-        foreign_key: vulnerability_id
-        table: vulnerabilities
-        sharding_key: project_id
-        belongs_to: vulnerability
-desired_sharding_key_migration_job_name: BackfillVulnerabilityStateTransitionsProjectId
 table_size: medium
+sharding_key:
+  project_id: projects

db/post_migrate/20250226084225_add_vulnerability_state_transitions_project_id_not_null.rb

+# frozen_string_literal: true
+
+class AddVulnerabilityStateTransitionsProjectIdNotNull < Gitlab::Database::Migration[2.2]
+  milestone '17.10'
+  disable_ddl_transaction!
+
+  def up
+    add_not_null_constraint :vulnerability_state_transitions, :project_id
+  end
+
+  def down
+    remove_not_null_constraint :vulnerability_state_transitions, :project_id
+  end
+end

db/schema_migrations/20250226084225

+5a1ff535b4a4b36c1c3a3be15233f01c121ad53085668cc248dec54c7e1c0649
\ No newline at end of file

db/structure.sql

@@ -24088,6 +24088,7 @@ CREATE TABLE vulnerability_state_transitions (
     comment text,
     dismissal_reason smallint,
     project_id bigint,
+    CONSTRAINT check_b6338547d4 CHECK ((project_id IS NOT NULL)),
     CONSTRAINT check_fe2eb6a0f3 CHECK ((char_length(comment) <= 50000))
 );