Merge branch 'sh-use-absolute-paths-gitaly-tests' into 'master'

Generate absolute paths for Gitaly test config files

See merge request gitlab-org/gitlab!53174

lib/gitlab/setup_helper.rb

@@ -121,7 +121,7 @@ def configuration_toml(gitaly_dir, storage_paths, options, gitaly_ruby: true)
 
           config[:'gitaly-ruby'] = { dir: File.join(gitaly_dir, 'ruby') } if gitaly_ruby
           config[:'gitlab-shell'] = { dir: Gitlab.config.gitlab_shell.path }
-          config[:bin_dir] = Gitlab.config.gitaly.client_path
+          config[:bin_dir] = File.expand_path(Gitlab.config.gitaly.client_path)
           config[:gitlab] = { url: Gitlab.config.gitlab.url }
           config[:logging] = { dir: Rails.root.join('log').to_s }
 

spec/support/helpers/test_env.rb

@@ -184,7 +184,7 @@ def gitaly_socket_path
   end
 
   def gitaly_dir
-    File.dirname(gitaly_socket_path)
+    File.dirname(File.expand_path(gitaly_socket_path))
   end
 
   def start_gitaly(gitaly_dir)