Merge branch 'mk/remove-no-longer-needed-check' into 'master'

Geo: Remove no longer needed check

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/175775



Merged-by: Vitali Tatarintev <vtatarintev@gitlab.com>
Approved-by: Natanael Silva <nsilva@gitlab.com>
Approved-by: Vitali Tatarintev <vtatarintev@gitlab.com>
Co-authored-by: Michael Kozono <mkozono@gitlab.com>

ee/app/graphql/types/geo/registry_type.rb

@@ -23,10 +23,8 @@ module RegistryType
         field :verification_checksum, GraphQL::Types::String, null: true, description: "The local checksum of the #{graphql_name}"
         field :verification_failure, GraphQL::Types::String, null: true, description: "Error message during verification of the #{graphql_name}"
 
-        # NOTE: remove respond_to? when GroupWikiRepositoryRegistry includes the verification state machine
-        # Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/323897
         def verification_state_name_value
-          object.verification_state_name.to_s.gsub('verification_', '') if object.respond_to?(:verification_state_name)
+          object.verification_state_name.to_s.gsub('verification_', '')
         end
       end
     end

ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb

@@ -132,13 +132,7 @@ def verification_data_to_registry_hash(data, registry)
     data['verificationFailure'] = registry.verification_failure
     data['verificationRetryCount'] = registry.verification_retry_count
     data['verificationStartedAt'] = registry.verification_started_at
-
-    # NOTE: remove respond_to? when GroupWikiRepositoryRegistry includes the verification state machine
-    # Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/323897
-    data['verificationState'] = if registry.respond_to?(:verification_state_name)
-                                  registry.verification_state_name.to_s.gsub('verification_', '').upcase
-                                end
-
+    data['verificationState'] = registry.verification_state_name.to_s.gsub('verification_', '').upcase
     data['verifiedAt'] = registry.verified_at if verification_enabled
     data['verificationRetryAt'] = registry.verification_retry_at if verification_enabled
     data