Merge branch 'move-target-blank-test-non-dynamic' into 'master'

Move file new tab check in new test

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/144958



Merged-by: Ezekiel Kigbo <3397881-ekigbo@users.noreply.gitlab.com>
Approved-by: Kos Palchyk <kpalchyk@gitlab.com>
Approved-by: Ezekiel Kigbo <3397881-ekigbo@users.noreply.gitlab.com>
Reviewed-by: Ezekiel Kigbo <3397881-ekigbo@users.noreply.gitlab.com>
Co-authored-by: lorenzvanherwaarden <lvanherwaarden@gitlab.com>

ee/spec/frontend/security_dashboard/components/shared/vulnerability_details_graphql/index_spec.js

@@ -381,6 +381,7 @@ describe('ee/security_dashboard/components/shared/vulnerability_details_graphql/
 
     describe('with location data', () => {
       const findFileLocation = () => wrapper.findByTestId('location-file-list-item');
+      const findFileLink = () => findFileLocation().findComponent(GlLink);
 
       const TEST_LOCATION = {
         file: 'index.js',
@@ -408,7 +409,7 @@ describe('ee/security_dashboard/components/shared/vulnerability_details_graphql/
 
       it('renders the file name as text', () => {
         expect(findFileLocation().text()).toContain('index.js');
-        expect(findFileLocation().findComponent(GlLink).exists()).toBe(false);
+        expect(findFileLink().exists()).toBe(false);
       });
 
       it.each`
@@ -432,6 +433,20 @@ describe('ee/security_dashboard/components/shared/vulnerability_details_graphql/
       });
 
       describe('with a blob path', () => {
+        it('opens file in a new tab', () => {
+          createComponent({
+            propsData: {
+              ...TEST_VULNERABILITY,
+              location: {
+                file: 'index.js',
+                blobPath: 'index.js',
+              },
+            },
+          });
+
+          expect(findFileLink().attributes('target')).toBe('_blank');
+        });
+
         it('does not append a line range when line numbers are not present', () => {
           createComponent({
             propsData: {
@@ -461,9 +476,7 @@ describe('ee/security_dashboard/components/shared/vulnerability_details_graphql/
             },
           });
 
-          const fileLink = findFileLocation().findComponent(GlLink);
-
-          expect(fileLink.attributes('href')).toBe(blobPath);
+          expect(findFileLink().attributes('href')).toBe(blobPath);
         });
 
         it.each`
@@ -490,11 +503,10 @@ describe('ee/security_dashboard/components/shared/vulnerability_details_graphql/
             });
 
             const { blobPath, file } = location;
-            const fileLink = findFileLocation().findComponent(GlLink);
+            const fileLink = findFileLink();
 
             expect(fileLink.attributes('href')).toBe(`${blobPath}#L${expectedLineRange}`);
             expect(fileLink.text()).toBe(`${file}:${expectedLineRange}`);
-            expect(fileLink.attributes('target')).toBe('_blank');
           },
         );
       });