Merge branch 'minac_add_desired_sharding_keys' into 'master'

Add desired sharding keys for some TI owned tables

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/144990



Merged-by: Tiger Watson <twatson@gitlab.com>
Approved-by: Tiger Watson <twatson@gitlab.com>
Reviewed-by: Manoj M J <mmj@gitlab.com>
Co-authored-by: Mehmet Emin INAC <minac@gitlab.com>

db/docs/sbom_occurrences_vulnerabilities.yml

 table_name: sbom_occurrences_vulnerabilities
+classes:
+  - Sbom::OccurrencesVulnerability
 feature_categories:
   - dependency_management
 milestone: '16.7'
 gitlab_schema: gitlab_main_cell
+desired_sharding_key:
+  project_id:
+    references: projects
+    backfill_via:
+      parent:
+        foreign_key: sbom_occurrence_id
+        table: sbom_occurrences
+        sharding_key: project_id
+        belongs_to: occurrence

db/docs/vulnerability_findings_remediations.yml

@@ -7,4 +7,13 @@ feature_categories:
 description: Join table between Remediations and Findings
 introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/47166
 milestone: '13.7'
-gitlab_schema: gitlab_main
+gitlab_schema: gitlab_main_cell
+desired_sharding_key:
+  project_id:
+    references: projects
+    backfill_via:
+      parent:
+        foreign_key: vulnerability_occurrence_id
+        table: vulnerability_occurrences
+        sharding_key: project_id
+        belongs_to: finding

ee/spec/lib/gitlab/database/desired_sharding_key_spec.rb

@@ -13,7 +13,10 @@
   end
 
   let(:allowed_to_be_missing_not_null) do
-    []
+    [
+      # column is missing NOT NULL constraint, but `belongs_to` association has `optional: false`, so we are good.
+      'vulnerability_findings_remediations.vulnerability_occurrence_id'
+    ]
   end
 
   it 'must reference an allowed referenced table' do