Merge branch...

Merge branch '406644-validate-positioning-of-model-experiments-menu-item-on-the-sidebar' into 'master'

Move Model experiments entry 'analyze'

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/125460



Merged-by: James Fargher <jfargher@gitlab.com>
Approved-by: Ross Byrne <robyrne@gitlab.com>
Approved-by: Taurie Davis <taurie@gitlab.com>
Approved-by: James Fargher <jfargher@gitlab.com>
Approved-by: Scott de Jonge <sdejonge@gitlab.com>
Co-authored-by: Eduardo Bonet <ebonet@gitlab.com>

lib/sidebars/projects/menus/packages_registries_menu.rb

@@ -98,7 +98,7 @@ def model_experiments_menu_item
           ::Sidebars::MenuItem.new(
             title: _('Model experiments'),
             link: project_ml_experiments_path(context.project),
-            super_sidebar_parent: Sidebars::Projects::SuperSidebarMenus::DeployMenu,
+            super_sidebar_parent: Sidebars::Projects::SuperSidebarMenus::AnalyzeMenu,
             active_routes: { controller: %w[projects/ml/experiments projects/ml/candidates] },
             item_id: :model_experiments
           )

lib/sidebars/projects/super_sidebar_menus/analyze_menu.rb

@@ -25,7 +25,8 @@ def configure_menu_items
             :code_review,
             :merge_request_analytics,
             :issues,
-            :insights
+            :insights,
+            :model_experiments
           ].each { |id| add_item(::Sidebars::NilMenuItem.new(item_id: id)) }
         end
       end

lib/sidebars/projects/super_sidebar_menus/deploy_menu.rb

@@ -20,8 +20,7 @@ def configure_menu_items
             :releases,
             :feature_flags,
             :packages_registry,
-            :container_registry,
-            :model_experiments
+            :container_registry
           ].each { |id| add_item(::Sidebars::NilMenuItem.new(item_id: id)) }
         end
       end

spec/lib/sidebars/projects/super_sidebar_menus/analyze_menu_spec.rb

@@ -23,7 +23,8 @@
       :code_review,
       :merge_request_analytics,
       :issues,
-      :insights
+      :insights,
+      :model_experiments
     ])
   end
 end

spec/lib/sidebars/projects/super_sidebar_menus/deploy_menu_spec.rb

@@ -18,8 +18,7 @@
       :releases,
       :feature_flags,
       :packages_registry,
-      :container_registry,
-      :model_experiments
+      :container_registry
     ])
   end
 end