Merge branch 'pl-spec-factories-predictive-create' into 'master'

CI: Skip testing factory creations in predictive and fail-fast jobs

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/149821



Merged-by: Lin Jen-Shin <jen-shin@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Lin Jen-Shin <jen-shin@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

ee/spec/models/factories_spec.rb

@@ -82,6 +82,7 @@
   ].freeze
 
   geo_configured = Gitlab.ee? && Gitlab::Geo.geo_database_configured?
+  check_create = !Support::GitlabCi.predictive_job? && !Support::GitlabCi.fail_fast_job?
 
   shared_examples 'factory' do |factory|
     skip_any = skipped.include?([factory.name, any])
@@ -107,7 +108,7 @@
         expect { build(factory.name) }.not_to raise_error
       end
 
-      it 'does not raise error when created' do
+      it 'does not raise error when created', if: check_create do
         pending 'Factory skipped linting due to legacy error' if skip_any
 
         expect { create(factory.name) }.not_to raise_error # rubocop:disable Rails/SaveBang
@@ -117,7 +118,7 @@
         skip_trait = skip_any || skipped.include?([factory.name, trait_name.to_sym])
 
         describe "linting :#{trait_name} trait" do
-          it 'does not raise error when created' do
+          it 'does not raise error when created', if: check_create do
             skip 'Trait skipped linting due to legacy error' if skip_trait
 
             expect { create(factory.name, trait_name) }.not_to raise_error

spec/support/helpers/gitlab_ci.rb

+# frozen_string_literal: true
+
+module Support
+  module GitlabCi
+    module_function
+
+    def predictive_job?
+      ENV['CI_JOB_NAME']&.include?('predictive')
+    end
+
+    def fail_fast_job?
+      ENV['CI_JOB_NAME']&.include?('fail-fast')
+    end
+  end
+end

spec/support_specs/helpers/gitlab_ci_spec.rb

+# frozen_string_literal: true
+
+require 'fast_spec_helper'
+require 'rspec-parameterized'
+
+require_relative '../../support/helpers/gitlab_ci'
+
+RSpec.describe Support::GitlabCi, feature_category: :tooling do # rubocop:disable RSpec/FilePath -- Avoid deep nesting
+  using RSpec::Parameterized::TableSyntax
+
+  describe '.predictive_job?' do
+    before do
+      stub_env('CI_JOB_NAME', name)
+    end
+
+    subject { described_class.predictive_job? }
+
+    where(:name, :expected) do
+      'rspec-ee unit predictive 4/4' | be_truthy
+      'rspec system predictive 1/4'  | be_truthy
+      'rspec unit 1/4'               | be_falsey
+      nil                            | be_falsey
+    end
+
+    with_them do
+      it { is_expected.to expected }
+    end
+  end
+
+  describe '.fail_fast_job?' do
+    before do
+      stub_env('CI_JOB_NAME', name)
+    end
+
+    subject { described_class.fail_fast_job? }
+
+    where(:name, :expected) do
+      'rspec fail-fast'              | be_truthy
+      'rspec-ee fail-fast'           | be_truthy
+      'rspec-ee unit predictive 4/4' | be_falsey
+      nil                            | be_falsey
+    end
+
+    with_them do
+      it { is_expected.to expected }
+    end
+  end
+end