Merge branch 'shl-remove-default-value-for-elastic-search-e2e-tests' into 'master'

Remove default value for ELASTIC_URL to avoid accidentally updating staging

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/179492



Merged-by: Dan Davison <ddavison@gitlab.com>
Approved-by: Dan Davison <ddavison@gitlab.com>
Approved-by: Arturo Herrero <arturo.herrero@gmail.com>
Co-authored-by: Sanad Liaquat (Personal) <sliaquat@gitlab.com>

.gitlab/ci/test-on-omnibus/main.gitlab-ci.yml

@@ -253,6 +253,7 @@ elasticsearch:
   extends: .qa
   variables:
     QA_SCENARIO: "Test::Integration::Elasticsearch"
+    ELASTIC_URL: "http://elastic68:9200"
   before_script:
     - !reference [.qa, before_script]
   rules:

qa/qa/ee/runtime/env.rb

@@ -22,7 +22,9 @@ def simple_saml_fingerprint
         end
 
         def elasticsearch_url
-          ENV.fetch('ELASTIC_URL', 'http://elastic68:9200')
+          ENV.fetch('ELASTIC_URL')
+        rescue KeyError
+          raise 'Please provide ELASTIC_URL for the environment you are running the tests'
         end
       end
     end