Merge branch 'fix-ee-api-search-rubocop' into 'master'

Fix EE API search Rubocop offenses

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/168032



Merged-by: Arturo Herrero <arturo.herrero@gmail.com>
Approved-by: Keeyan Nejad <knejad@gitlab.com>
Approved-by: Niko Belokolodov <nbelokolodov@gitlab.com>

.rubocop_todo/lint/constant_definition_in_block.yml

@@ -22,7 +22,6 @@ Lint/ConstantDefinitionInBlock:
     - 'ee/app/models/ee/user.rb'
     - 'ee/app/models/ee/vulnerability.rb'
     - 'ee/app/services/ee/notes/quick_actions_service.rb'
-    - 'ee/lib/ee/api/search.rb'
     - 'ee/lib/gitlab/subscription_portal/clients/rest.rb'
     - 'ee/lib/tasks/geo.rake'
     - 'ee/spec/db/schema_support.rb'

.rubocop_todo/style/guard_clause.yml

@@ -331,7 +331,6 @@ Style/GuardClause:
     - 'ee/lib/ee/api/features.rb'
     - 'ee/lib/ee/api/helpers/projects_helpers.rb'
     - 'ee/lib/ee/api/projects.rb'
-    - 'ee/lib/ee/api/search.rb'
     - 'ee/lib/ee/gitlab/auth/ldap/access.rb'
     - 'ee/lib/ee/gitlab/auth/ldap/sync/group.rb'
     - 'ee/lib/ee/gitlab/auth/o_auth/user.rb'

ee/lib/ee/api/search.rb

@@ -9,8 +9,6 @@ module Search
         helpers do
           extend ::Gitlab::Utils::Override
 
-          ELASTICSEARCH_SCOPES = %w[wiki_blobs blobs commits notes].freeze
-
           override :scope_preload_method
           def scope_preload_method
             super.merge(blobs: :with_api_commit_entity_associations).freeze
@@ -18,14 +16,18 @@ def scope_preload_method
 
           override :verify_search_scope!
           def verify_search_scope!(resource:)
-            if ELASTICSEARCH_SCOPES.include?(params[:scope]) && !use_elasticsearch?(resource)
-              render_api_error!({ error: 'Scope not supported without Elasticsearch!' }, 400)
-            end
+            return unless elasticsearch_scope.include?(params[:scope]) && !use_elasticsearch?(resource)
+
+            render_api_error!({ error: 'Scope not supported without Elasticsearch!' }, 400)
           end
 
           def use_elasticsearch?(resource)
             ::Gitlab::CurrentSettings.search_using_elasticsearch?(scope: resource)
           end
+
+          def elasticsearch_scope
+            %w[wiki_blobs blobs commits notes].freeze
+          end
         end
       end
     end