Merge branch '429000-add-index-for-partitioned-pk-on-ci_pipeline_variables' into 'master'

Synchronous migration to include partition_id on ci_pipeline_variables

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/137777



Merged-by: Marius Bobin <mbobin@gitlab.com>
Approved-by: Max Orefice <morefice@gitlab.com>
Approved-by: Marius Bobin <mbobin@gitlab.com>
Reviewed-by: Max Orefice <morefice@gitlab.com>
Co-authored-by: panoskanell <pkanellidis@gitlab.com>

db/post_migrate/20231129132636_prepare_indexes_for_partitioning_ci_pipeline_variables.rb

+# frozen_string_literal: true
+
+class PrepareIndexesForPartitioningCiPipelineVariables < Gitlab::Database::Migration[2.2]
+  milestone '16.7'
+  disable_ddl_transaction!
+
+  TABLE_NAME = :ci_pipeline_variables
+  PK_INDEX_NAME = :index_ci_pipeline_variables_on_id_partition_id_unique
+  UNIQUE_INDEX_NAME = :index_pipeline_variables_on_pipeline_id_key_partition_id_unique
+
+  def up
+    add_concurrent_index(TABLE_NAME, %i[id partition_id], unique: true, name: PK_INDEX_NAME)
+    add_concurrent_index(TABLE_NAME, %i[pipeline_id key partition_id], unique: true, name: UNIQUE_INDEX_NAME)
+  end
+
+  def down
+    remove_concurrent_index_by_name(TABLE_NAME, PK_INDEX_NAME)
+    remove_concurrent_index_by_name(TABLE_NAME, UNIQUE_INDEX_NAME)
+  end
+end

db/post_migrate/20231130131808_remove_indexes_without_partition_id_from_ci_pipeline_variables.rb

+# frozen_string_literal: true
+
+class RemoveIndexesWithoutPartitionIdFromCiPipelineVariables < Gitlab::Database::Migration[2.2]
+  milestone '16.7'
+  disable_ddl_transaction!
+
+  TABLE_NAME = :ci_pipeline_variables
+  OLD_UNIQUE_INDEX_NAME = :index_ci_pipeline_variables_on_pipeline_id_and_key
+
+  def up
+    remove_concurrent_index_by_name(TABLE_NAME, OLD_UNIQUE_INDEX_NAME)
+  end
+
+  def down
+    add_concurrent_index(TABLE_NAME, %i[pipeline_id key], unique: true, name: OLD_UNIQUE_INDEX_NAME)
+  end
+end

db/schema_migrations/20231129132636

+1bdc6128604324a7bebec587ed935dfd2e91838f36e3ca68fadf695a48b32d24
\ No newline at end of file

db/schema_migrations/20231130131808

+20c7fd677cfa00821b67761f9d406d1bf4cfdf65831c3c96910ccb43986b9926
\ No newline at end of file

db/structure.sql

@@ -32174,7 +32174,7 @@ CREATE INDEX index_ci_pipeline_schedules_on_owner_id_and_id_and_active ON ci_pip
 CREATE INDEX index_ci_pipeline_schedules_on_project_id ON ci_pipeline_schedules USING btree (project_id);
-CREATE UNIQUE INDEX index_ci_pipeline_variables_on_pipeline_id_and_key ON ci_pipeline_variables USING btree (pipeline_id, key);
+CREATE UNIQUE INDEX index_ci_pipeline_variables_on_id_partition_id_unique ON ci_pipeline_variables USING btree (id, partition_id);
 CREATE INDEX index_ci_pipelines_config_on_pipeline_id ON ci_pipelines_config USING btree (pipeline_id);
@@ -33940,6 +33940,8 @@ CREATE INDEX index_personal_access_tokens_on_user_id ON personal_access_tokens U
 CREATE INDEX index_pipeline_metadata_on_pipeline_id_name_text_pattern ON ci_pipeline_metadata USING btree (pipeline_id, name text_pattern_ops);
+CREATE UNIQUE INDEX index_pipeline_variables_on_pipeline_id_key_partition_id_unique ON ci_pipeline_variables USING btree (pipeline_id, key, partition_id);
+
 CREATE UNIQUE INDEX index_plan_limits_on_plan_id ON plan_limits USING btree (plan_id);
 CREATE UNIQUE INDEX index_plans_on_name ON plans USING btree (name);