Disable method replacement in avatar loading
We've seen a significant performance penalty when using `BatchLoader#__replace_with!`. This defines methods on the batch loader that proxy to the 'real' object using send. The alternative is `method_missing`, which is slower. However, we've noticed that `method_missing` can be faster if: 1. The objects being loaded have a large interface. 2. We don't call too many methods on the loaded object. Avatar uploads meet both criteria above, so let's use the newly-released feature in https://github.com/exAspArk/batch-loader/pull/45. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60903
显示
- Gemfile 1 个添加, 1 个删除Gemfile
- Gemfile.lock 2 个添加, 2 个删除Gemfile.lock
- app/models/concerns/avatarable.rb 2 个添加, 1 个删除app/models/concerns/avatarable.rb
- changelogs/unreleased/sh-disable-batch-load-replace-methods.yml 5 个添加, 0 个删除...logs/unreleased/sh-disable-batch-load-replace-methods.yml
- spec/uploaders/object_storage_spec.rb 8 个添加, 0 个删除spec/uploaders/object_storage_spec.rb
加载中
想要评论请 注册 或 登录