Skip to content
代码片段 群组 项目
提交 25101d20 编辑于 作者: Reuben Pereira's avatar Reuben Pereira
浏览文件

Remove pipeline_name_search feature flag

This enables filtering of pipelines by name in the public pipelines
API.

Changelog: added
上级 8f4ef655
No related branches found
No related tags found
无相关合并请求
...@@ -149,9 +149,7 @@ def by_yaml_errors(items) ...@@ -149,9 +149,7 @@ def by_yaml_errors(items)
# rubocop: enable CodeReuse/ActiveRecord # rubocop: enable CodeReuse/ActiveRecord
def by_name(items) def by_name(items)
return items unless return items unless params[:name].present?
Feature.enabled?(:pipeline_name_search, project) &&
params[:name].present?
items.for_name(params[:name]) items.for_name(params[:name])
end end
......
---
name: pipeline_name_search
introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/107086
rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/385864
milestone: '15.7'
type: development
group: group::delivery
default_enabled: false
...@@ -19,12 +19,7 @@ Read more on [pagination](rest/index.md#pagination). ...@@ -19,12 +19,7 @@ Read more on [pagination](rest/index.md#pagination).
> - `name` in response [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115310) in GitLab 15.11 [with a flag](../administration/feature_flags.md) named `pipeline_name_in_api`. Disabled by default. > - `name` in response [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115310) in GitLab 15.11 [with a flag](../administration/feature_flags.md) named `pipeline_name_in_api`. Disabled by default.
> - `name` in request [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115310) in 15.11 [with a flag](../administration/feature_flags.md) named `pipeline_name_search`. Disabled by default. > - `name` in request [introduced](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/115310) in 15.11 [with a flag](../administration/feature_flags.md) named `pipeline_name_search`. Disabled by default.
> - `name` in response [generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/398131) in GitLab 16.3. Feature flag `pipeline_name_in_api` removed. > - `name` in response [generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/398131) in GitLab 16.3. Feature flag `pipeline_name_in_api` removed.
> - `name` in request [generally available](https://gitlab.com/gitlab-org/gitlab/-/issues/385864) in GitLab 16.9. Feature flag `pipeline_name_search` removed.
FLAG:
On self-managed GitLab, by default the `name` field in a request is ignored.
To make it available, an administrator can [enable the feature flag](../administration/feature_flags.md)
named `pipeline_name_search`.
On GitLab.com, this feature is available.
List pipelines in a project. Child pipelines are not included in the results, List pipelines in a project. Child pipelines are not included in the results,
but you can [get child pipeline](pipelines.md#get-a-single-pipeline) individually. but you can [get child pipeline](pipelines.md#get-a-single-pipeline) individually.
......
...@@ -259,16 +259,6 @@ ...@@ -259,16 +259,6 @@
is_expected.to be_empty is_expected.to be_empty
end end
end end
context 'when pipeline_name_search feature flag is off' do
before do
stub_feature_flags(pipeline_name_search: false)
end
it 'ignores name parameter' do
is_expected.to contain_exactly(pipeline, pipeline_other)
end
end
end end
describe 'ordering' do describe 'ordering' do
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册