Skip to content
代码片段 群组 项目
未验证 提交 24811360 编辑于 作者: Amy Qualls's avatar Amy Qualls 提交者: GitLab
浏览文件

Merge branch '497573-adjust-code-review-language-removal' into 'master'

Remove guidance to remove yourself as a reviewer after reviewing a MR

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/172701



Merged-by: default avatarAmy Qualls <aqualls@gitlab.com>
Approved-by: default avatarMichael Becker <mbecker@gitlab.com>
Approved-by: default avatarRémy Coutable <remy@rymai.me>
Approved-by: default avatarAmy Qualls <aqualls@gitlab.com>
Reviewed-by: default avatarRémy Coutable <remy@rymai.me>
Co-authored-by: default avatarDoug Stull <dstull@gitlab.com>
No related branches found
No related tags found
无相关合并请求
......@@ -425,7 +425,6 @@ that it meets all requirements, you should:
- `@` mention the author to generate a to-do notification, and advise them that their merge request has been reviewed and approved.
- Request a review from a maintainer. Default to requests for a maintainer with [domain expertise](#domain-experts),
however, if one isn't available or you think the merge request doesn't need a review by a [domain expert](#domain-experts), feel free to follow the [Reviewer roulette](#reviewer-roulette) suggestion.
- Remove yourself as a reviewer.
### The responsibility of the maintainer
......@@ -463,7 +462,8 @@ If a developer who happens to also be a maintainer was involved in a merge reque
as a reviewer, it is recommended that they are not also picked as the maintainer to ultimately approve and merge it.
Maintainers should check before merging if the merge request is approved by the
required approvers. If still awaiting further approvals from others, remove yourself as a reviewer then `@` mention the author and explain why in a comment. Stay as reviewer if you're merging the code.
required approvers.
If still awaiting further approvals from others, `@` mention the author and explain why in a comment.
Certain merge requests may target a stable branch. For an overview of how to handle these requests,
see the [patch release runbook](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/engineers.md).
......@@ -478,8 +478,6 @@ Here is a summary of the changes, also reflected in this section above.
- Merge request authors and DRIs stay as Assignees.
- Authors request a review by assigning users as Reviewers.
- Reviewers unassign themselves after they're done reviewing and approving.
- The last approver (who merges the MR) stays assigned as Reviewer.
## Best practices
......
......@@ -80,7 +80,7 @@ A database **reviewer**'s role is to:
- Perform a first-pass review on the MR and suggest improvements to the author.
- Once satisfied, relabel the MR with ~"database::reviewed", approve it, and
request a review from the database **maintainer** suggested by Reviewer
Roulette. Remove yourself as a reviewer once this has been done.
Roulette.
A database **maintainer**'s role is to:
......@@ -90,7 +90,6 @@ A database **maintainer**'s role is to:
- Finally approve the MR and relabel the MR with ~"database::approved"
- Merge the MR if no other approvals are pending or pass it on to
other maintainers as required (frontend, backend, documentation).
- If not merging, remove yourself as a reviewer.
### Distributing review workload
......
0% 加载中 .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册